Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CasC allows duplicate entries for single valued Describables without warning. #2589

Open
jtnord opened this issue Nov 4, 2024 · 1 comment
Labels

Comments

@jtnord
Copy link
Member

jtnord commented Nov 4, 2024

Jenkins and plugins versions report

Environment

from jenkinsci/oic-auth-plugin#436 , otherwise unknown

What Operating System are you using (both controller, and any agents involved in the problem)?

N/A

Reproduction steps

  1. Create a config as code snippet with 2 different conflicting options for a describable.

e.g.

jenkins:
  securityRealm:
    oic:
      serverConfiguration:
        # Automatic config of endpoint
        wellKnown:
          wellKnownOpenIDConfigurationUrl: "https://myid.com/.well-known/openid-configuration"
        # Manual config of endpoint
        manual:
          authorizationServerUrl: "https://myid.com/authorize"
          issuer: "https://myid.com/"
          jwksServerUrl: "https://myid.com/jwks"
          tokenServerUrl: "https://myid.com/token"
          userInfoServerUrl: "https://myid.com/userInfo"
          useRefreshTokens: false
      # Credentials
      clientId: "myclient-01"
      clientSecret: "supersecret"
      # claims
  1. start Jenkins with this casc file

serverConfiguration is a single valued Describable, yet the config contains two conflicting values for the above.

Expected Results

the startup should error or warn as the configuration is invalid

Actual Results

no warning / error

Anything else?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants