Were you able to test the update on https://github.com/CodexRaunak/plugin-modernizer-bucket/blob/main/plugin-modernizer.json and the cd workflow ?

I dont' see any automatic commit there

Hello,
I am new to contributing to this repository and have a few questions. Here's what I've done so far:

1)Created the manifest file for the bucket and pushed it to the bucket repository, which is currently under my ownership.
2)Hardcoded the changelist with the version (which i will correct now and pass it as -Dset.changelist) and created a new release with JReleaser on my forked repository.
3)Installed the tool using Scoop on my Windows machine.

Can you help me with the following?
1)Ownership of the Bucket: Since the bucket should ideally be under the jenkins-infra organization, I attempted to transfer ownership to them. However, I encountered an issue as I didn’t have permission to create public repositories under the jenkins-infra organization. Could you clarify what I should do next? Should I transfer the repository, or is there another solution?

2)Testing Changes and Automatic Commits: How do I properly test changes after making the updates and creating the release? Also, I would appreciate guidance on ensuring that the automatic commit process works as expected. Could you point me to any resources that could help me understand how to test the changes and ensure automatic commits are made?

Hi,

For the repository we will need to ask the creation of it under the jenkins-infra. Once this PR is ready we can open an helpdesk ticket on https://github.com/jenkins-infra/helpdesk/issues

JReleaser is supposed to automatically update the file

I'm not sure you can fully test the CD workflow but you can perform jreleaser on your machine targeting your forks

I was using something like

jreleaser -Djreleaser.project.version=$(mvn -q -Dset.changelist -Dignore.dirt -DforceStdout org.apache.maven.plugins:maven-help-plugin:evaluate -Dexpression=project.version) package
jreleaser -Djreleaser.project.version=$(mvn -q -Dset.changelist -Dignore.dirt -DforceStdout org.apache.maven.plugins:maven-help-plugin:evaluate -Dexpression=project.version) publish

Also a quick look on https://jreleaser.org/guide/latest/reference/packagers/scoop.html

The env var JRELEASER_SCOOP_GITHUB_TOKEN is not set on https://github.com/jenkins-infra/plugin-modernizer-tool/blob/main/.github/workflows/cd.yaml#L115C11-L115C42

I would suggest to try to test the workflow (or at least part of it) before requesting the creation of a new repo under the jenkins-infra organisation

Hope it helps

To merged when the repo is provisionned on jenkins-infra

I would also like to test on one bucket https://github.com/jonesbusy/scoop-bucket before

I've raised jenkins-infra/helpdesk#4468

I've also tested the publish and result of https://github.com/jonesbusy/scoop-bucket/blob/main/bucket/plugin-modernizer.json

Sadly I don't have a Windows environment to test now but I think it's looking pretty neat

My only concern is this part

  "checkver": {
    "url": "https://github.com/jonesbusy/plugin-modernizer-tool/releases/latest",
    "re": "v([\\d.]+).jar"
  },

I don't know if the updates will be detected ? Our versioning scheme like 1098.vd063a_8b_4fcdf will not match this regex

@CodexRaunak Did you test the update ? Do you know if we can customize this regex ?

It should be something like

-([\\d.]+)\\.(.*).jar (untested)

to detect the first part of the version which increment

The above regex you mentioned -([\\d.]+)\\.(.*).jar needs a little correction on the \\ part
This \\ is not detecting the version rather single \ is working -([\d.]+)\.(.*).jar fine.

https://regexr.com/ I tested the regex on this tester.
Also we can be bit more specfic than .* like ([\d]+)\.([a-zA-Z0-9_]+)\.jar . These both are working fine but the lower one is more specefic.

Also it will select the - from the URL, so if we don't need the hyphen part just remove it from the regex start.

@jonesbusy I have been testing the workflow, but facing an issue, do you have any idea why the CI test is not validating , and resolves to false

I believe its because of this line ID=$(gh api -X GET -F check_name="$NAME" -F status=completed /repos/$GITHUB_REPOSITORY/commits/$GITHUB_SHA/check-runs | jq -e '.check_runs | .[] | select(.conclusion == "success") | .id' || echo 'failed') in the run.sh. I am stuck on trouble shooting it.

The above regex you mentioned -([\\d.]+)\\.(.*).jar needs a little correction on the \\ part This \\ is not detecting the version rather single \ is working -([\d.]+)\.(.*).jar fine.

https://regexr.com/ I tested the regex on this tester. Also we can be bit more specfic than .* like ([\d]+)\.([a-zA-Z0-9_]+)\.jar . These both are working fine but the lower one is more specefic.

Also it will select the - from the URL, so if we don't need the hyphen part just remove it from the regex start.

Thanks!

For the CI is because the workflow check the status on ci.jenkins.io. It will not work on your fork. You can only test some part of the workflow (like jreleaser)

Ahh i see, well thanks

I confirm it work with current setup (Back to work, I can test on Windows)

When we have the bucket on jenkins-infra we can merge and test the CD workflow for and end2end test. But I'm quite confident it work