-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Caching Metadata Retrieval for Repeated Runs #208
Comments
Yea that's the correct behavior for now. There are some TODO in the code // TODO: For now it's always null because we don't persist nor cache metadata
if (metadata == null) {
LOG.info("Metadata is not yet computed for plugin {}. Using minimum JDK available", plugin.getName());
jdk = JDK.min();
} else {
jdk = plugin.getJDK();
} The cache also as some hardcoded expiration of 1h which is way too short for most object. Most likely need to be fixed also when we store those file on a remote location |
Implemented for local cache. Open discussion for a repository on jenkins-infra jenkins-infra/helpdesk#4262 |
Other idea would be to use OCI storage I started the development of https://github.com/jonesbusy/oras-java which should be moved to https://github.com/oras-project during October Nowadays many tools are using OCI storage to store images, manifests etc (Helm, Flux CD, etc...) Even updatecli is doing it https://www.updatecli.io/docs/commands/updatecli_manifest_push/ We could easily store such medata on the GitHub package of this repository |
Great idea! |
SDK was finally transfered under the oras-project organisation: https://github.com/oras-project/oras-java I will try to work on publication/release in the upcoming weeks and we can test itegration in plugin-modernizer |
That would also allow us to store the data about the PR created thanks to the tool... (#647). |
What feature do you want to see added?
Current Behavior
When launching the same command to fetch metadata for a set of plugins, the tool reports "Metadata is not yet computed for plugin git." even on the second execution.
Desired Behavior
I would like the tool to retrieve the metadata from a local file when running the same command repeatedly on the same machine for the same list of plugins.
Proposed Solution
Implement a caching mechanism for the metadata retrieval process to avoid redundant computation.
Benefits of Caching Metadata
Implementation Considerations
Next Steps
Your feedback and suggestions on this proposed improvement would be greatly appreciated.
Upstream changes
No response
Are you interested in contributing this feature?
No response
The text was updated successfully, but these errors were encountered: