Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValidableContract, CleansAttributes fails save when used inside job. #160

Open
olivernybroe opened this issue Feb 11, 2017 · 3 comments
Open

Comments

@olivernybroe
Copy link

olivernybroe commented Feb 11, 2017

I have been stuck on this annoying bug in a long time and finally realised it was caused by validable.

The problem is when trying to create an model inside a job the eloquence Hookable save() returns false.

If I however set skipValidation = true then it passes the save, but saves an empty model, because CleansAttributes just removes everything.
If I however removes the implementation of CleansAttributes and has skipValidation = true, then I saves the model as intended.

Running Laravel 5.2

@dikos
Copy link

dikos commented Mar 24, 2017

I have the same problem. If CleansAttributes interface is used, then nothing is saved on model. It's just empty.
Using Laravel 5.3

@jarektkaczyk
Copy link
Owner

What was exactly the problem here?

@olivernybroe
Copy link
Author

As said in the bug description, When creating a model inside a job, then the save function fails.

It looks like a bug with CleansAttributes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants