Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remote engine management #4364

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from
Open

feat: remote engine management #4364

wants to merge 7 commits into from

Conversation

urmauur
Copy link
Member

@urmauur urmauur commented Dec 30, 2024

Describe Your Changes

This pull request introduces several changes related to engine management, including the addition of new types, modifications to existing methods, and updates to the user interface for handling engines. The most important changes are summarized below:

Engine Management Enhancements:

  • Added EngineConfig and EngineMetadata types in core/src/types/engine/index.ts to encapsulate engine configuration and metadata details.
  • Updated methods in EngineManagementExtension and JSONEngineManagementExtension to use the new EngineConfig type, improving consistency and flexibility.

New Functionality:

  • Introduced a new method getRemoteModels in EngineManagementExtension and JSONEngineManagementExtension to fetch remote models.

User Interface Updates:

  • Added showSettingActiveRemoteEngineAtom to manage the state of active remote engines in web/helpers/atoms/Extension.atom.ts.
  • Created a new component LocalEngineItems to display and manage local engine settings in web/screens/Settings/Engines/LocalEngineItem.tsx.
  • Renamed Settings.tsx to LocalEngineSettings.tsx and updated its content to reflect the changes in engine management.

Dependency Updates:

  • Added new dependencies @hookform/resolvers, react-hook-form, and zod to web/package.json for improved form handling and validation.

Fixes Issues

  • Form to add new remote engine

CleanShot 2024-12-30 at 22 14 18

CleanShot 2024-12-30 at 22 14 24

  • Show remote engine list in Engine setting page
  • Show remote engine list in setting left panel based toggle active

CleanShot 2024-12-30 at 22 15 30

  • Detail page for remote engine

CleanShot 2024-12-30 at 22 17 49

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@urmauur urmauur added the type: feature request A new feature label Dec 30, 2024
@urmauur urmauur added this to the v0.5.13 milestone Dec 30, 2024
@urmauur urmauur requested a review from louis-jan December 30, 2024 15:20
@urmauur urmauur self-assigned this Dec 30, 2024
Copy link
Contributor

github-actions bot commented Dec 30, 2024

Barecheck - Code coverage report

Total: 68.72%

Your code coverage diff: 0.01% ▴

Uncovered files and lines
FileLines
core/src/browser/extensions/enginesManagement.ts18
web/helpers/atoms/Extension.atom.ts25
web/hooks/useActiveModel.ts45, 49-50, 53-54, 56, 58, 60, 62, 64, 66-67, 72, 78, 82-83, 92, 94, 97-99, 102-103, 108, 115, 121-122, 125, 130-131, 137-139, 141-142, 144, 146-148, 156-158, 160, 162-163
web/hooks/useCreateNewThread.ts138-139, 141-142, 149-150, 161, 170, 207, 211, 213

@urmauur urmauur force-pushed the feat/remote-engine branch from 00fb6c0 to 7dc5efc Compare January 6, 2025 07:47
@urmauur urmauur deployed to production January 6, 2025 07:47 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Implement UI for Remote Engine Management
3 participants