Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common events trigger too fast #56

Open
ahh opened this issue Mar 23, 2022 · 0 comments · May be fixed by #143
Open

common events trigger too fast #56

ahh opened this issue Mar 23, 2022 · 0 comments · May be fixed by #143
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ahh
Copy link

ahh commented Mar 23, 2022

If I run a particular trace for an event I expect to be trigger very often (say expected 1000Hz) then as soon as magic trace starts recording, it stops. As a consequence I get a very limited history.

While my software trigger could be written to only probabalistically trigger I'd like it if magic trace had an option "refuse to trigger until we've been recording for TIME-SPAN".
@Xyene Xyene added enhancement New feature or request good first issue Good for newcomers labels Mar 23, 2022
Xyene added a commit to Xyene/magic-trace that referenced this issue Apr 11, 2022
@Xyene
Add -min-trigger-time to delay installing breakpoint
c846898 
This allows capturing traces with `-trigger` symbols that get called
with very high (possibly bursty) frequency, where we otherwise migt
trigger before the snapshot buffer has a chance to fill up.

Closes janestreet#56.

Signed-off-by: Tudor Brindus <[email protected]>
@Xyene Xyene linked a pull request Apr 11, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add -min-trigger-time to delay installing breakpoint Xyene/magic-trace
2 participants
@ahh @Xyene