Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design Review Finalization Tweaks #29

Open
LFrancis23 opened this issue Dec 6, 2022 · 0 comments
Open

Design Review Finalization Tweaks #29

LFrancis23 opened this issue Dec 6, 2022 · 0 comments
Assignees
Labels
Firmware Firmware specific issues Keys board All things for the board with keys Main board Issues specific to the main board with the power and cpu Nicety Not crucial to meeting spec but would be good if we have time
Milestone

Comments

@LFrancis23
Copy link
Collaborator

There is a bunch of little things that should be improved for design review. They include but are not limited to the following.

  1. LED Functionality: The LED's onboard should be doing more things, some of which I am thinking of are: Mute Indicator, Keyboard connected indicator, Display connected indicator.
  2. MIDI Velocity: MIDI velocity should work better, I want to try and get the full 0-127 range if possible.
  3. Volume Knob: Increment/Decrement by more than one, probably 10-15 turns for full range so probably around 9-10 values per tick.
  4. MIDI Mute: Mute doesn't actually mute, it just kills the active notes, this should be changed. Also add functionality for unmute. Likely requires a "muted" flag in the keyboard struct. Maybe this can be embedded in the volume value? If the max volume is 127, that is |0111|1111| We can use the MSB as a "muted" bit meaning no matter the lower seven, keep volume at zero.
  5. Print the current octave and volume.
@LFrancis23 LFrancis23 added Firmware Firmware specific issues Nicety Not crucial to meeting spec but would be good if we have time Main board Issues specific to the main board with the power and cpu Keys board All things for the board with keys Critical Issues which are required to meet spec labels Dec 6, 2022
@LFrancis23 LFrancis23 self-assigned this Dec 6, 2022
@LFrancis23 LFrancis23 added this to the Design Review milestone Dec 6, 2022
@LFrancis23 LFrancis23 removed the Critical Issues which are required to meet spec label Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Firmware Firmware specific issues Keys board All things for the board with keys Main board Issues specific to the main board with the power and cpu Nicety Not crucial to meeting spec but would be good if we have time
Projects
None yet
Development

No branches or pull requests

1 participant