Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QR-Code Security Enforcements #504

Open
peppelinux opened this issue Nov 22, 2024 · 2 comments
Open

QR-Code Security Enforcements #504

peppelinux opened this issue Nov 22, 2024 · 2 comments
Assignees
Milestone

Comments

@peppelinux
Copy link
Member

openid/OpenID4VP#329 (comment)

It would be beneficial to include the following in the QR code:

A nonce
An expiration time (exp)

The Relying Party (RP) should bind the user-agent with the issued QR code in such a way that a scam attack would not succeed unless the adversary knows and configures their user-agent with the same data as the victim's user-agent.

@fmarino-ipzs
Copy link
Collaborator

@peppelinux @grausof this is something that we should handle in milestone 0.9. WDYT?

@peppelinux
Copy link
Member Author

No it is only an open discussion with several concerns and weakness, I only tried to explain some further key elements but it is still not clear how they would appear as usefull or necessary for the improvement of the security of the qr-code

no action for now, even because nonce and exp is something that can be explicitly handled by the RP in its backend, using bindings and expiration times after the issuance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants