Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve annotation loading procedure in s1_reader.burst_from_xml #67

Open
seongsujeong opened this issue Aug 28, 2022 · 0 comments
Open

Improve annotation loading procedure in s1_reader.burst_from_xml #67

seongsujeong opened this issue Aug 28, 2022 · 0 comments
Assignees
@seongsujeong
Labels
enhancement New feature or request needs triage Issue requires triage to proceed

Comments

@seongsujeong
Copy link
Contributor

Checked for duplicates

Yes - I've already checked

Alternatives considered

Yes - and alternatives don't suffice

Related problems

s1_reader.burst_from_xml() includes annotation reader. The logic can be improved by applying the comment below:

(#62 (comment))

Describe the feature request

I need the logic for annotation reader to take in zipfile object, rather than xml tree, so that the s1_reader.burst_from_xml() can be less populated.
@seongsujeong seongsujeong added enhancement New feature or request needs triage Issue requires triage to proceed labels Aug 28, 2022
@seongsujeong seongsujeong self-assigned this Aug 28, 2022
@seongsujeong seongsujeong mentioned this issue Aug 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seongsujeong seongsujeong

Labels
enhancement New feature or request needs triage Issue requires triage to proceed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@seongsujeong