Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onednn to gemm benchmarks #3014

Open
alexbaden opened this issue Dec 16, 2024 · 1 comment · May be fixed by #3040
Open

Add onednn to gemm benchmarks #3014

alexbaden opened this issue Dec 16, 2024 · 1 comment · May be fixed by #3040
Assignees

Comments

@alexbaden
Copy link
Contributor

Currently we compare xetla and triton, but can compare onednn as well.

@alexbaden alexbaden self-assigned this Dec 16, 2024
@alexbaden alexbaden linked a pull request Dec 18, 2024 that will close this issue
2 tasks
@vlad-penkin vlad-penkin linked a pull request Dec 18, 2024 that will close this issue
2 tasks
@alexbaden
Copy link
Contributor Author

This needs a bit of a re-think - the current microbenchmark infrastructure uses the onednn kernel name to benchmark only the kernel time (and ignore the pytorch bits around the kernel). However, pytorch is not able to fuse many matmul operations (e.g. dot w/ add) into a single kernel - if we use the existing infra for those benchmarks, then we will be comparing the onednn matmul kernel to the triton matmul + add fused kernel, when I think we want to be comparing total pytorch execution time with total triton (fused) execution time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants