Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

color resources do nothing and forbid use of attributes #2

Open
ursusursus opened this issue Feb 23, 2024 · 0 comments
Open

color resources do nothing and forbid use of attributes #2

ursusursus opened this issue Feb 23, 2024 · 0 comments

Comments

@ursusursus
Copy link

ursusursus commented Feb 23, 2024

Docs say override these colors

<color name="dot_face_auto_capture_instruction_text">@color/green</color>
<color name="dot_face_auto_capture_instruction_text_background">#FFAABB</color>
<color name="dot_face_auto_capture_instruction_text_stay_still">#FFEEAA</color>
<color name="dot_face_auto_capture_instruction_text_background_stay_still">#FF9800</color>
<color name="dot_eye_gaze_liveness_instruction_text">#ffffaabb</color>
<color name="dot_eye_gaze_liveness_instruction_text_background">#FF9800</color>

and these are not used in runtime, only colors that actually do something are these

<color name="dot_instruction_text">@color/facelift_black</color>
<color name="dot_instruction_background">@color/white</color>
<color name="dot_instruction_candidate_selection_background">@color/red</color>
<color name="dot_placeholder">@color/dot_instruction_background</color>
<color name="dot_placeholder_candidate_selection">@color/dot_instruction_candidate_selection_background</color>
<color name="dot_placeholder_overlay">@color/white_a30</color>

Also, library breaks styling via color attributes, for example

<color name="dot_instruction_text">?attr/colorOnSurface</color>

this crashes in runtime due to library using context.getColor, which is wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant