Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent file handle leaks from Compactor.write on errors [port to main-2.x] #25739

Open
davidby-influx opened this issue Jan 3, 2025 · 0 comments · May be fixed by #25740
Open

prevent file handle leaks from Compactor.write on errors [port to main-2.x] #25739

davidby-influx opened this issue Jan 3, 2025 · 0 comments · May be fixed by #25740
Assignees
@davidby-influx
Labels
area/tsm kind/bug team/edge

Comments

@davidby-influx
Copy link
Contributor

Port #25724 to main-2.x
@davidby-influx davidby-influx self-assigned this Jan 3, 2025
davidby-influx added a commit that referenced this issue Jan 3, 2025
@davidby-influx
fix: do not leak file handles from Compactor.write (#25725)
ef73376 
There are a number of code paths in Compactor.write which
on error can lead to leaked file handles to temporary files.
This, in turn, prevents the removal of the temporary files until
InfluxDB is rebooted, releasing the file handles.

closes #25724

(cherry picked from commit e974165)

closes #25739
@davidby-influx davidby-influx linked a pull request Jan 3, 2025 that will close this issue
Open
@davidby-influx davidby-influx linked a pull request Jan 3, 2025 that will close this issue
fix: do not leak file handles from Compactor.write (#25725) #25740
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidby-influx davidby-influx

Labels
area/tsm kind/bug team/edge
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: do not leak file handles from Compactor.write (#25725) influxdata/influxdb
1 participant
@davidby-influx