Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compaction edge case bugs #25666

Open
devanbenz opened this issue Dec 16, 2024 · 0 comments
Open

Compaction edge case bugs #25666

devanbenz opened this issue Dec 16, 2024 · 0 comments
Assignees
@devanbenz
Labels
1.x area/tsm kind/bug

Comments

@devanbenz
Copy link

devanbenz commented Dec 16, 2024 •
edited
Loading

There are a few logical bugs in our compaction planner that are stopping TSM files from being compacted in certain edge cases:

  • Compaction does not take in to account single generation TSM files that can be further compacted.
    • More then single file and group size is under 2 GB
  • Compaction skips file groups if any of the files (or file groups add up) to over the 2GB max TSM file size.
@devanbenz devanbenz self-assigned this Dec 16, 2024
devanbenz added a commit that referenced this issue Dec 16, 2024
@devanbenz
feat: Modify optimized compaction to cover edge cases
d631314 
This PR changes the algorithm for compaction to account for the following
cases that were not previously accounted for:

- Many generations with a groupsize over 2 GB
- Single generation with many files and a groupsize under 2 GB
Where groupsize is the total size of the TSM files in said shard directory.

closes #25666
devanbenz added a commit that referenced this issue Jan 14, 2025
@devanbenz
feat: Modify optimized compaction to cover edge cases (#25594)
f04105b 
* feat: Modify optimized compaction to cover edge cases
This PR changes the algorithm for compaction to account for the following
cases that were not previously accounted for:

- Many generations with a groupsize over 2 GB
- Single generation with many files and a groupsize under 2 GB
- Where groupsize is the total size of the TSM files in said shard directory.
- shards that may have over a 2 GB group size but
many fragmented files (under 2 GB and under aggressive
point per block count)

closes #25666
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devanbenz devanbenz

Labels
1.x area/tsm kind/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@devanbenz