Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect_URI allowlist #41

Open
dshanske opened this issue Apr 25, 2018 · 5 comments
Open

Redirect_URI allowlist #41

dshanske opened this issue Apr 25, 2018 · 5 comments

Comments

@dshanske
Copy link
Member

dshanske commented Apr 25, 2018

Currently, the plugin only supports redirect_uris on the same domain as the client_id. The spec calls for having the client_id have a allowlist of acceptable redirect_uris that can be polled. This is not yet supported.

@aaronpk alternatively alllows this to be overridden by issuing a warning in the authorization screen, as opposed to what the plugin does, which is reject it.

https://indieauth.spec.indieweb.org/#redirect-url

@aaronpk
Copy link
Member

aaronpk commented Apr 26, 2018

Here's what my auth endpoint shows when there is a mismatch.

screenshot 2018-04-26 06 43 37

If the redirect_uri and client_id have the same domain then that notice is not shown.

@aaronpk
Copy link
Member

aaronpk commented May 3, 2018

In case people are searching for the error message they see, the wordpress plugin currently shows this when encountering this error:

{"error":"invalid_grant","error_description":"Redirect not on same host as client"}

@miklb
Copy link
Contributor

miklb commented May 23, 2018

I'm currently experiencing this issue with Indigenous.

@dshanske
Copy link
Member Author

This was changed in version 2.0.2

@dshanske
Copy link
Member Author

dshanske commented May 23, 2018

The issue is still open as it warns, but doesn't check for a allowlist

@dshanske dshanske changed the title Redirect_URI whitelist Redirect_URI allowlist Dec 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants