format filtering returns everything when passed an unknown format

[andybak]

https://api.icosa.gallery/v1/assets?format=asd

To discuss - what do we want to happen here?

[jamesrampton]

Perhaps we should return nothing. This is the behaviour for keywords, for example and it makes sense. However, the way it's been coded is to explicitly return all (i.e, it's not an oversight). I don't recall what our thinking around this originally was (nor should I have to - more comments!) so I'm happy to go with whatever you feel works best.

[andybak]

It's either return nothing or return a 40x

I lean towards the latter.

[jamesrampton]

I'm leaning towards the former! This is a filter, not the base URL. I think a 404 would be confusing for clients. Imagine the case that we 404 for a keyword search. That wouldn't make much sense.

Happy to be convinced though.

[andybak]

I was actually thinking more of "400 Bad Request" - does that change things, at all?

[jamesrampton]

That changes everything :^) I've implemented this.