Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: show h2 threads in scoreboard #23

Open
covener opened this issue May 28, 2015 · 2 comments
Open

Feature: show h2 threads in scoreboard #23

covener opened this issue May 28, 2015 · 2 comments

Comments

@covener
Copy link
Contributor

covener commented May 28, 2015

It seems like we need a way to do one of:

  • move the threadpool into something managed by the core or MPM and include extra scoreboard handles at creation time (this happens really early though)
  • ask the MPM's to schedule and run the h2 threads (probably easiest in event)
  • find a way for a module to ask for an over-allocation the scoreboard handles AND coordinate thread offsets.

This would allow the h2 threads to have their actual slots int he scoreboard. Currently they all share the original connection processing threads scoreboard handle and mockup some event internal structures

@icing
Copy link
Owner

icing commented Jun 11, 2015

I had a closer look at scoreboard and what it does. And looked at /server-status after some loadtesting. Seeing threads that go into 'G' and never leave that state. Does not look ok, afaik.

As first mitigation, added some ap_update_child_status() into my main I/O handling. But that does not solve the problem.

For the 2.4 release, I need a way for mod_h2 to co-exist with its own threads, since I think substantial changes in MPMs are not going to fly.

@icing icing changed the title scoreboard handles for h2 threads Feature: scoreboard handles for h2 threads Sep 2, 2015
@icing icing changed the title Feature: scoreboard handles for h2 threads Feature: show h2 threads in scoreboard Mar 31, 2016
@icing
Copy link
Owner

icing commented Mar 31, 2016

So, the scoreboard (mod-status) can be extended, as see by balancers and ssl. Use this extension mechanism to display the status of all active http2 workers. Show request being processed and progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants