Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example 07_gltf renders materials incorrectly #14

Closed
hoelzl opened this issue Jan 9, 2019 · 5 comments
Closed

Example 07_gltf renders materials incorrectly #14

hoelzl opened this issue Jan 9, 2019 · 5 comments

Comments

@hoelzl
Copy link

hoelzl commented Jan 9, 2019

When running example 07_gltf the materials appear very different from the ones in the WebGL version:

07_gltf_d_2019-01-09_18-58-33

07_gltf_d_2019-01-09_18-58-54

07_gltf_d_2019-01-09_18-59-12

(Built from the latest master (00fc8af) using VS2017 on Windows 10 Pro 64 bit with GeForce GTX 1080 graphics card, driver version 417.35, 4k monitor.)

@hoelzl hoelzl changed the title Example 07_glts renders materials incorrectly Example 07_gltf renders materials incorrectly Jan 9, 2019
@hugoam
Copy link
Owner

hugoam commented Jan 10, 2019

Strangely, this might be related to #11.
In this one you don't get a crash, but it seems what's missing is the generation of the prefiltered environment map (which is precisely the shader that is crashing in #11).
Maybe try running in D3D mode like I advised in the other issue so we can know more about this issue.

@hoelzl
Copy link
Author

hoelzl commented Jan 10, 2019

It seems you're right. When running in D3D mode the image looks perfect.

@hugoam
Copy link
Owner

hugoam commented Jan 10, 2019

Could you give me the logs for this one too ? I want to be sure that the cause is indeed related to the other issue.

@hoelzl
Copy link
Author

hoelzl commented Jan 10, 2019

It seems that this issue was solved by f38fdcf for OpenGL as well. Just in case they are still of interest to you I've attached logs for the latest version with the glitch (74a83bf _old) and a post-fix build (_new).

07_gltf_console_output_old.txt
07_gltf_debug_output_old.txt

07_gltf_console_output_new.txt
07_gltf_debug_output_new.txt

@hugoam
Copy link
Owner

hugoam commented Jan 11, 2019

Oh, right, I just saw that I updated the shaders also in that commit, so if they were out-of-date that could explain all sorts of visual issues.

@hugoam hugoam closed this as completed Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants