Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't publish charts with semver build postfix (aka, cr breaks if + in chart version) #56

Open
itewk opened this issue Nov 4, 2020 · 1 comment

Comments

@itewk
Copy link

itewk commented Nov 4, 2020

Issue

helm states that the version in Chart.yaml supports SemVer, which includes an option for a build section (+BUILD) (https://semver.org/#backusnaur-form-grammar-for-valid-semver-versions).

But, when i try to use the chart releaser with a helm chart with a version of 0.1.0-edge1+SHA-abc123 it fails, if I drop the + to 0.1.0-edge1 it works. based on the error message it looks like some issues with escaping the +.

Logs

Run helm/[email protected]
tssc-tekton-cloud-resources
Looking up latest tag...
Discovering changed charts since 'ceed80e8ab27acbabccbbd21434b43ee19d0abfb'...
Installing chart-releaser...
Packaging chart 'charts/tssc-workflow-tekton-cluster-resources'...
Successfully packaged chart and saved it to: .cr-release-packages/tssc-workflow-tekton-cluster-resources-0.1.0-edge8+shaceed80e8.tgz
Packaging chart 'charts/tssc-workflow-tekton-pipeline'...
walk.go:74: found symbolic link in path: /home/runner/work/tssc-tekton-cloud-resources/tssc-tekton-cloud-resources/charts/tssc-workflow-tekton-pipeline/charts/tssc-workflow-tekton-shared-resources resolves to /home/runner/work/tssc-tekton-cloud-resources/tssc-tekton-cloud-resources/charts/tssc-workflow-tekton-shared-resources
walk.go:74: found symbolic link in path: /home/runner/work/tssc-tekton-cloud-resources/tssc-tekton-cloud-resources/charts/tssc-workflow-tekton-pipeline/charts/tssc-workflow-tekton-shared-resources resolves to /home/runner/work/tssc-tekton-cloud-resources/tssc-tekton-cloud-resources/charts/tssc-workflow-tekton-shared-resources
Successfully packaged chart and saved it to: .cr-release-packages/tssc-workflow-tekton-pipeline-0.1.0-edge8+shaceed80e8.tgz
Packaging chart 'charts/tssc-workflow-tekton-shared-resources'...
Successfully packaged chart and saved it to: .cr-release-packages/tssc-workflow-tekton-shared-resources-0.1.0-edge8+shaceed80e8.tgz
Releasing charts...
+ cr index -o itewk -r tssc-tekton-cloud-resources -c https://itewk.github.io/tssc-tekton-cloud-resources
Updating charts repo index...
====> UpdateIndexFile new index at .cr-index/index.yaml
Error: .cr-release-packages/tssc-workflow-tekton-cluster-resources-0.1.0-edge8%2Bshaceed80e8.tgz is not a helm chart package: stat .cr-release-packages/tssc-workflow-tekton-cluster-resources-0.1.0-edge8%2Bshaceed80e8.tgz: no such file or directory
====> Found tssc-workflow-tekton-cluster-resources-0.1.0-edge8+shaceed80e8.tgz
Usage:
  cr index [flags]
@jlpedrosa
Copy link

Same here, actually the hot potatoe is in the mix between GH which provides a link url escaped (https://github.com/jlpedrosa/helm-chart/releases/download/2.11.2%2BChart1/unpoller-2.11.2+Chart1.tgz) and the chart releaser, not the action.

helm/chart-releaser#406 this fixes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants