Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support client preferred cipher order #418

Open
josephcsible opened this issue Feb 3, 2020 · 5 comments
Open

Support client preferred cipher order #418

josephcsible opened this issue Feb 3, 2020 · 5 comments

Comments

@josephcsible
Copy link

Currently, onCipherChoosing only receives ciphers in the server's preferred order, making it impossible to support client preferred cipher order (as Apache does via SSLHonorCipherOrder off). Mozilla's TLS guidelines recommend that client-preferred ciphers be used when no weak ciphers are present, so we should add an option to do this.

@ocheron
Copy link
Contributor

ocheron commented Feb 22, 2020

We can have an option for this but I'm not sure this is so useful.
The client may have better crypto implementation than the server.

@josephcsible
Copy link
Author

I'm not sure how that makes it not so useful.

@ocheron
Copy link
Contributor

ocheron commented Feb 29, 2020

The recommendation implicitly assumes the server is more likely to have hardware acceleration. But it's not necessarily true, the build mechanisms do not do a great job at auto-enabling what the platform can provide. As of now for example optimized GCM is hidden behind a cabal flag and AESNI is not available on Windows.

@josephcsible
Copy link
Author

In general, servers don't care that much about power consumption, and have a lot of beefy CPUs. Clients can be phones, smart watches, or IoT devices, though, which have much tighter power requirements (due to battery drain) and less spare CPU. Because of this, if the client doesn't have AES acceleration (even if the server does), I'd prefer that it get to use ChaCha20.

@ocheron
Copy link
Contributor

ocheron commented Jul 19, 2020

OK, a PR is welcome if there are end users impacted by this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants