Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All 404 paths go to a page requesting an issue submission for a broken link #1753

Closed
SeanGallen opened this issue Aug 10, 2024 · 3 comments
Closed

Comments

@SeanGallen
Copy link
Contributor

SeanGallen commented Aug 10, 2024

I notice a few issues suggesting a broken link but I could not find these links. After exploring the site, I notice any 404 path in the URL shows a Page Not Found UI with the request to submit an issue for a broken link. On the 404 page there is a link which creates a boilerplate issue.
Example: https://graphql.org/random-path/ generates an issue titled Found broken /random-path link. Please fix!

I cannot speak directly to issues #1726 and #1748, but maybe the wording should change or the page should redirect to the home page? People may have bookmarked pages which don't exist anymore but the site suggests something is broken. This could create a lot of unnecessary issues.
Either way, I could be missing something so I wanted to raise the question. Thanks for all the hard work.

@benjie
Copy link
Member

benjie commented Dec 19, 2024

We should never break links; if a page once existed and no longer does, we should redirect to the newest resource that replaces it. I've no idea where the /debugging link came from (git log -S'/debugging' did not turn up any hits) or if that page ever really existed, but to help us catch these issues I raised:

to include the referring page. Mostly we want to be notified if we've accidentally deleted a page that someone had bookmarked.

@saihaj
Copy link
Member

saihaj commented Dec 23, 2024

Agreed with @benjie in an ideal world we wouldn't break any links. I added a task so in some framework migration we never break a page #1911 this will help us ensure in CI that we don't break anything before merging.

As for Issue templates in a worst case or for any old stuff where folks have pages bookmarked and we broke the page we would want to know how it happened so we do want to keep that flow.

@saihaj saihaj closed this as completed Dec 23, 2024
@SeanGallen
Copy link
Contributor Author

SeanGallen commented Dec 23, 2024

Thank you both for the explanations. I was concerned with too many false issues being created but I understand and respect the points you both made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants