Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect spec text for "Empty Merged Object Type" rule #80

Open
glen-84 opened this issue Dec 25, 2024 · 1 comment
Open

Incorrect spec text for "Empty Merged Object Type" rule #80

glen-84 opened this issue Dec 25, 2024 · 1 comment

Comments

@glen-84
Copy link
Contributor

glen-84 commented Dec 25, 2024

As a post-merge validation rule, it should look at the merged schema, not at the source schemas.

@PascalSenn
Copy link
Contributor

The empty merged object type rule currenlty is:

- Let {types} be the set of all input object types in the composite schema.
- For each {type} in {types}:
  - Let {fields} be a set of all fields in {type}.
  - {fields} must not be empty.

I think this is fixed.

But also, for certain post validation rules its valid to access the source schemas. The post merge validation still has the context of all source schemas. Depending on the implementation, this meta information is stored on the execution schema (e.g. super graph document in federation or execution schema in fusion). Yet, the specification does not assume how you want to preserve this information. It would be completely valid for a implementation to not have an "execution schema" but keep each source schema around for execution too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants