Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-merge validation rules with overlapping behavior #79

Open
glen-84 opened this issue Dec 23, 2024 · 0 comments
Open

Pre-merge validation rules with overlapping behavior #79

glen-84 opened this issue Dec 23, 2024 · 0 comments

Comments

@glen-84
Copy link
Contributor

glen-84 commented Dec 23, 2024 •
edited
Loading

There are some rules in this document that appear to overlap.

Examples:

  • EXTERNAL_ARGUMENT_DEFAULT_MISMATCH and FIELD_ARGUMENT_DEFAULT_MISMATCH
  • EXTERNAL_ARGUMENT_MISSING and REQUIRED_ARGUMENT_MISSING_IN_SOME_SCHEMA
  • EXTERNAL_ARGUMENT_TYPE_MISMATCH and FIELD_ARGUMENT_TYPE_MISMATCH
  • EXTERNAL_TYPE_MISMATCH and FIELD_TYPE_MISMATCH

If the non-external rule would check both non-external and external arguments/fields, then why does there need to be another rule specifically for external arguments/fields?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@glen-84