Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: a run mutation #335

Open
ZacSweers opened this issue Jul 5, 2021 · 3 comments
Open

Feature request: a run mutation #335

ZacSweers opened this issue Jul 5, 2021 · 3 comments

Comments

@ZacSweers
Copy link

While there are a number of mutations today for defining scenarios, we've found them unhelpful in some cases due to either being too trivial or too limiting. I'd like to propose a new run mutation that would act similar to git bisect run, where an arbitrary shell script + any arguments is given. This would be invoked before each iteration to apply a set of changes handled by the script.

One example where we would want to use this is to apply changes that would specifically change the dependency graph in a build profiling Dagger, such as adding a parameter to an injected class's constructor. This would give flexibility for scenario authors to profile specific cases unique to their build.

@ZacSweers
Copy link
Author

If you're open to this, I'd gladly look at contributing a PR for this

@wolfs
Copy link
Member

wolfs commented Jul 14, 2021

@ZacSweers Is this PR more or less what you are looking for? #310

@ZacSweers
Copy link
Author

Yup that's exactly what I'm looking for 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants