-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resolved Gradle version to action outputs #259
Comments
…oh, but I had assumed that the provisioned version would be available in Gradle user home's wrappers, but that doesn't seem to be the case, so that would mean downloading the ZIP twice in the code above. |
So you mean that TestKit is re-downloading the distribution even after it was downloaded as part of "setup-gradle". This is currently the expected behaviour because the provisioned versions are not stored under Gradle User Home. However, it would be useful if we could find a way to cache a single copy of the distribution for provisioned Gradle and wrappers. It would be even better if this could be built into Gradle itself, so that if a Gradle version is already provisioned then we'd never have to download the same wrapper. |
The issue I'm seeing is that gradle-build-action is not requesting "other" Gradle versions (non-primary, used by TestKit). In this build there is a set of Gradle versions being tested - for each run on GHA these are re-downloaded, and then stored in the cache - because they are never requested to be restored. Perhaps an option to "use/store all distributions" (that have been used, following existing logic) or "use/store these distributions".
|
@cloudshiftchris This sounds like a different issue, and something we should investigate and fix. Can you please open a separate GH issue with as much detail as possible? Thanks. |
@tbroyer However, I've opened gradle/actions#22 for the key use case of avoiding re-download of Gradle distributions. |
It would be great to have the resolved Gradle version as an output of the action; that way one could use
gradle-version: current
and later pass that version as input to the Gradle build (to be passed to the Gradle TestKit, that requires a specific version).actions/setup-java
for instance exposes theversion
andpath
of the provisioned JDK.For example here, always testing with the current stable version without having to update the workflow every time:
The text was updated successfully, but these errors were encountered: