Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out why clippy seems to be not working properly #764

Open
jaytaph opened this issue Jan 12, 2025 · 1 comment
Open

Figure out why clippy seems to be not working properly #764

jaytaph opened this issue Jan 12, 2025 · 1 comment
Labels
github actions Any issues related to Github actions good first issue Good for newcomers

Comments

@jaytaph
Copy link
Member

jaytaph commented Jan 12, 2025

When we do a "make fix-format", clippy should be able to reformat our code properly.. The CI system should be able to check for any issues and fail if there are formatting issues. Somehow, it seems that code that is not formatted properly still passes the CI..

We should make sure that only correctly formatted code passes, otherwise when contributers do a fix-format locally, it will add (many) changes unrelated to their PR and makes it harder to review.

@jaytaph jaytaph added good first issue Good for newcomers github actions Any issues related to Github actions labels Jan 12, 2025
@mdimado
Copy link

mdimado commented Jan 13, 2025

I'm interested in working on this issue but am new to this codebase. Could you please provide some guidance to help me get started? Specifically:

  1. Are there specific files or scripts where the CI configuration for formatting checks is defined?
  2. What tool or process does the make fix-format command use to reformat code ?
  3. Any tips on how I can locally test the updated CI configuration to ensure it works as expected?

Thanks in advance for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github actions Any issues related to Github actions good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants