You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When we do a "make fix-format", clippy should be able to reformat our code properly.. The CI system should be able to check for any issues and fail if there are formatting issues. Somehow, it seems that code that is not formatted properly still passes the CI..
We should make sure that only correctly formatted code passes, otherwise when contributers do a fix-format locally, it will add (many) changes unrelated to their PR and makes it harder to review.
The text was updated successfully, but these errors were encountered:
When we do a "make fix-format", clippy should be able to reformat our code properly.. The CI system should be able to check for any issues and fail if there are formatting issues. Somehow, it seems that code that is not formatted properly still passes the CI..
We should make sure that only correctly formatted code passes, otherwise when contributers do a fix-format locally, it will add (many) changes unrelated to their PR and makes it harder to review.
The text was updated successfully, but these errors were encountered: