Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ungoogled-chromium browser value #189

Open
erazemk opened this issue Jan 6, 2021 · 2 comments
Open

Add ungoogled-chromium browser value #189

erazemk opened this issue Jan 6, 2021 · 2 comments

Comments

@erazemk
Copy link

erazemk commented Jan 6, 2021

This request stems from an issue mentioned in #188.

Ungoogled Chromium uses a custom ~/.config/ directory, so choosing chromium as a browser option in gopass-jsonapi configure doesn't work.
Please consider adding an option for ungoogled chromium, which should copy the com.justwatch.gopass.json to $HOME/.config/ungoogled-chromium/NativeMessagingHosts/com.justwatch.gopass.json.

@Pharb
Copy link
Member

Pharb commented Feb 13, 2021

Thank you for the suggestion. Sounds like a good improvement.

With the latest changes this issue belongs now to the gopass-jsonapi repository.

The code where we handle these browsers can be found here - I'm happy to review a PR there: https://github.com/gopasspw/gopass-jsonapi/blob/main/internal/jsonapi/manifest/setup_others.go#L18

@martinhoefling Do you maybe have the permissions to transfer this issue to the new gopass-jsonapi repository? Github just gives we strange errors when I try it :(

@erazemk
Copy link
Author

erazemk commented Feb 17, 2021

@njenan I've recently switched to Brave, so I don't know where in /etc ungoogled-chromium stores messaging hosts, can you please tell me?

I'm guessing it something like /etc/ungoogled-chromium/native-messaging-hosts for the global path and ~/.config/ungoogled-chromium/NativeMessagingHosts for the local one, but I wanna be sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants