Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete key comparison in clone #3028

Open
14mRh4X0r opened this issue Jan 3, 2025 · 0 comments
Open

Incomplete key comparison in clone #3028

14mRh4X0r opened this issue Jan 3, 2025 · 0 comments
Labels
bug Defects gpg GPG related

Comments

@14mRh4X0r
Copy link

Summary

On gopass clone with GPG, gopass checks whether we already have access to the cloned repository by comparing our usable keys to the keys listed in .gpg-id. However, this is a string comparison. While .gpg-id allows for any GPG-approved way to specify a key, gopass will use short form keys (e.g. 0x17F3ED51DADD9393) to compare.

Steps To Reproduce

  1. Have a repository with one of your keys in a non-short form in .gpg-id
  2. gopass clone the repository
  3. gopass will reply with "Please ask the owner of the password store to add one of your keys"

Expected behavior

In step 3: gopass will reply with "Found valid decryption keys. You can now decrypt your passwords."

Environment

  • OS: Arch Linux
  • OS version: Linux vischium 6.11.5-arch1-1 Add template feature #1 SMP PREEMPT_DYNAMIC Tue, 22 Oct 2024 18:31:38 +0000 x86_64 GNU/Linux
  • gopass Version: gopass 1.15.15 go1.23.3 linux amd64
  • Installation method: pacman
@dominikschulz dominikschulz added bug Defects gpg GPG related labels Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Defects gpg GPG related
Projects
None yet
Development

No branches or pull requests

2 participants