autosync = false breaks manual sync

[mcnesium]

Setting core.autosync = false breaks manual syncing with gopass sync command. It then just does nothing (it seems):

19:44:07 mcn@x2b ~ grep sync .config/gopass/config 
autosync=false

19:44:54 mcn@x2b ~ time gopass sync
🚥 Syncing with all remotes ...
✅ All done

real	0m0,437s
user	0m0,270s
sys	0m0,179s

In pretty much no time it "syncs" and states all being done, while actually not at all syncing. When setting core.autosync = true it then does it also manually:

19:44:57 mcn@x2b ~ grep sync .config/gopass/config 
autosync=true

19:45:39 mcn@x2b ~ time gopass sync
🚥 Syncing with all remotes ...
[<root>] 
   gitfs pull and push ... OK (no changes)
   done
   …

I prefer it not autosyncing, because I find it annoying to wait for the syncing of >20 stores when I only want to use the command line tool. So I have set autosync.interval = 9999 to work around this issue. Is there another way to do that?

gopass 1.15.15 go1.23.4 linux amd64 on NixOS unstable with home.packages = with pkgs; [ gopass gopass-jsonapi ];

[dominikschulz]

core.autosync = false should not affect gopass sync. This looks like a bug.

[TM2500]

I think it is

gopass/internal/action/sync.go

Line 164 in ffe0234

if as := s.cfg.GetM(mp, "core.autosync"); as == "false" {

Maybe we should do this check only if in autosync context.
I courrently don't know if we mark autosync as state in ctx.
But if we do it should be a quick fix.

[TM2500]

Since syncMount has only two callees (all in this package, actually only in this file), it would not hurt to change the signature with an autosync flag either.

[TM2500]

I created a draft PR (#3029) with a fix.
I went with storeing a autosync state in context as it better fits with the current practice.

There are tests missing for this use-case.
So I will look into it and create some.