Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial render of Google Pay's plain button min-width is 240px #292

Open
1 of 3 tasks
vsashyn opened this issue May 27, 2024 · 3 comments
Open
1 of 3 tasks

Initial render of Google Pay's plain button min-width is 240px #292

vsashyn opened this issue May 27, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@vsashyn
Copy link

vsashyn commented May 27, 2024

Describe the bug
Safari only. With buttonType="plain" the style min-width=240px is applied during button's initial render, even though it seems this min-width is relevant only to pay button type.

To Reproduce
I'm not able to reproduce on Customize your button. It seems selection of button type in dropdown rerenders button and there is no min-width.

Steps to reproduce:

  1. Go to Wix test site
  2. See Google Pay button that is outside of the wrapping container. Sometimes it is not reproducible from first attempt. Also, please try different window sizes. Although there is a container which sets width, style min-width:240px is present in Google Pay button.

Expected behavior
Google Pay button fits into the outer container.

Screenshots
Screenshot 2024-05-27 at 19 12 06
Screenshot 2024-05-27 at 19 14 01

Component information:

  • Component
    • React component (@google-pay/button-react)
    • Custom element (@google-pay/button-element)
    • Angular component (@google-pay/button-angular)
  • Component version (e.g. 3.0.10):

Environment:

  • Device (MacBook Pro):
  • OS (macOS 14.4.1):
  • Browser (Safari)
  • Country/region: Europe
@vsashyn vsashyn added the bug Something isn't working label May 27, 2024
@jnsdrssn
Copy link

would buttonType="short" work for you? That did the trick for me, has a min width of 90px

@dmengelt
Copy link
Member

@vsashyn / @jnsdrssn we are looking into this. so sorry for the inconvenience...

@dmengelt dmengelt changed the title [Safari] During initial render Google Pay's button min-width is 240px Initial render of Google Pay's plain button min-width is 240px Jun 28, 2024
@dmengelt
Copy link
Member

Potential workarounds for now:.

  1. Use buttonType: 'short' (as you mentioned already)
  2. Share your Google Pay merchantId here and I will add it to a deny list. This will no longer show dynamic card info on the button.
Y145O

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants