-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/go: GOCACHEPROG needs real documentation #71032
Comments
Related Issues
(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.) |
Change https://go.dev/cl/638567 mentions this issue: |
Change https://go.dev/cl/638566 mentions this issue: |
Change https://go.dev/cl/638996 mentions this issue: |
Change https://go.dev/cl/638995 mentions this issue: |
Change https://go.dev/cl/638997 mentions this issue: |
Change https://go.dev/cl/638378 mentions this issue: |
This is in preparation for adding a "go help" topic for GOCACHEPROG. Updates #71032 Updates #59719 Change-Id: I9dbbe56fa328dffe89207b5b41a0f37afd51e2b5 Reviewed-on: https://go-review.googlesource.com/c/go/+/638566 LUCI-TryBot-Result: Go LUCI <[email protected]> Auto-Submit: Austin Clements <[email protected]> Reviewed-by: Michael Matloob <[email protected]>
This is a step toward making it easy to point to them in documentation. The other option is that we copy-paste all of these type definitions wholesale, which seems ridiculous. Updates #71032 Updates #59719 Change-Id: I7117e03308ae0adc721ed7a57792c33ba68ce827 Reviewed-on: https://go-review.googlesource.com/c/go/+/638995 Auto-Submit: Austin Clements <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Michael Matloob <[email protected]>
Now that these types are in their own package, drop the unnecessary Prog prefixes from everything. Updates #71032 Updates #59719 Change-Id: Id54edf0473754e3b21a71beb72803fb5481206c1 Reviewed-on: https://go-review.googlesource.com/c/go/+/638996 Reviewed-by: Mauri de Souza Meneguzzo <[email protected]> Reviewed-by: Michael Matloob <[email protected]> Reviewed-by: Brad Fitzpatrick <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Auto-Submit: Austin Clements <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
Currently the release notes link to the proposal for GOCACHEPROG, which isn't ideal and is also slightly outdated. CL 638995 moves the protocol documentation to its own package that we can link to and that can't get out of date, so point the release notes at this documentation. For golang/go#71032 Change-Id: I8d4db0a0153333b40f9021f030a36184546bfe51 Reviewed-on: https://go-review.googlesource.com/c/website/+/638378 Auto-Submit: Austin Clements <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>
GOCACHEPROG
will be enabled by default in Go 1.24. Currently, the only documentation on this appears to be #59719 (comment), which is quite terse and not completely up-to-date.We should add a real documentation page on this setting and the protocol, probably to the cmd/go documentation. Once we've done this, we should also update the 1.24 release notes to point to the documentation instead of #59719.
The text was updated successfully, but these errors were encountered: