Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl-Click on enum value/member does nothing #101089

Open
mooflu opened this issue Jan 3, 2025 · 3 comments · May be fixed by #101127
Open

Ctrl-Click on enum value/member does nothing #101089

mooflu opened this issue Jan 3, 2025 · 3 comments · May be fixed by #101127

Comments

@mooflu
Copy link

mooflu commented Jan 3, 2025

Tested versions

  • reproducible in: 4.4.dev7
  • reproducible on master (tested with a 03-Jan-2025 build - v4.4.dev.gh-101012 [c37ada786])
  • works in: 4.4.dev6

System information

Godot v4.4.dev7 - Windows 11 (build 22631) - Multi-window, 1 monitor - OpenGL 3 (Compatibility) - NVIDIA GeForce RTX 2070 SUPER (NVIDIA; 32.0.15.6636) - 13th Gen Intel(R) Core(TM) i7-13700KF (24 threads)

Issue description

I mentioned this here: #100680 (comment)
While general control-click was restored with #100707 the enum issue remains.

CTRL-clicking on an enum value/member does nothing (well, it actually navigates to the beginning of the line).

E.g. enum like this:

class_name E extends Object

enum Team {
	None,
	One,
}

func test():
	var t = E.Team.None

and CTRL-clicking on the None of E.Team.None does not take you to the None under enum Team.

Steps to reproduce

Open enum.gd in MRP - same code as in description.

Minimal reproduction project (MRP)

44dev7enum.zip

@carsonetb
Copy link
Contributor

carsonetb commented Jan 4, 2025

Hi, I was looking at your bug and messing around, and some very weird things were happening ... here's a video in 4.4.dev7.

20250104-0356-29.2744435.mp4

It seems that changing the class's documentation updates something and it suddenly works.

I couldn't reproduce this behavior at all in master ... it just goes to the class's documentation page.

@mooflu
Copy link
Author

mooflu commented Jan 4, 2025

Hi, I was looking at your bug and messing around, and some very weird things were happening ... here's a video in 4.4.dev7. https://github.com/user-attachments/assets/90ab71d5-b7aa-428e-b8d5-bb237c101167

It seems that changing the class's documentation updates something and it suddenly works.

I couldn't reproduce this behavior at all in master ... it just goes to the class's documentation page.

Yes, ctrl-click change #100707 went into master after dev7.

@carsonetb
Copy link
Contributor

carsonetb commented Jan 4, 2025

Okay that makes sense but still that behavior where adding documentation effects Ctrl+click is very weird... can you reproduce it on your computer?

@github-project-automation github-project-automation bot moved this to For team assessment in GDScript Issue Triage Jan 4, 2025
@AThousandShips AThousandShips added this to the 4.4 milestone Jan 4, 2025
@dalexeev dalexeev moved this from For team assessment to Fix pending review in GDScript Issue Triage Jan 4, 2025
@dalexeev dalexeev moved this from Unassessed to Bad in 4.x Release Blockers Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Bad
Status: Fix pending review
Development

Successfully merging a pull request may close this issue.

3 participants