Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password prompt: add a show password button like the password stage #12550

Open
tmassimi opened this issue Jan 3, 2025 · 1 comment
Open
Assignees
Labels
enhancement/confirmed Enhancements that will be implemented in the future enhancement New feature or request

Comments

@tmassimi
Copy link
Contributor

tmassimi commented Jan 3, 2025

allow_show_password: When enabled, provides a 'show password' button with the password input field.

the setting is available only in the stage Password, so if you want to have username and password on the same form (not a stage password) it is not possible to enable it.

IMHO, allow_show_password should be a global setting: if True the button should be available on each password request; in this way the user interface could be more coherent and the code simpler

Tasks

Preview Give feedback
No tasks being tracked yet.
@tmassimi tmassimi added the bug Something isn't working label Jan 3, 2025
@rissson rissson changed the title allow_show_password is not a global settings Password prompt: add a show password button like the password stage Jan 6, 2025
@rissson rissson added enhancement New feature or request enhancement/confirmed Enhancements that will be implemented in the future and removed bug Something isn't working labels Jan 6, 2025
@rissson
Copy link
Member

rissson commented Jan 6, 2025

There's one more place I can think of where we asks users to enter password, and that's on the set password form in the admin interface

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement/confirmed Enhancements that will be implemented in the future enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants