-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The custom error addition should handle edge cases #322
Comments
Good ideas |
I'd love to give this a go. |
May I be assigned to this? |
@EwenQuim Can I take this issue? |
Anyone is welcome to take this as it's pretty wide open. I guess to be to close this we would need to test all the content-type options inputtabl for this scenario. Right now we only test The best thing would be to add a table of content types here and test then. https://github.com/go-fuego/fuego/blob/main/serve_test.go#L637 Hope this helps! |
Could I try solving this? |
Hey @ryzen-xp feel free. Some work had been started on this. Please see this comment for closable acceptance criteria. #322 (comment) |
Could I take over this issue? |
Could I grab this task? |
Is it okay if I tackle this? |
1 similar comment
Is it okay if I tackle this? |
Holla i'm Martin, I'm a frontend developer who enjoys building smooth applications to pixel perfect and engaging websites using JavaScript, typescript and frameworks(React, nextjs, tailwindcss etc.) and i have contributed to other projects that have been merged. |
May I be assigned to this? |
As stated before anyone is welcome to take this issue. Feel free to take the initiative! 😄 |
Let me try this one! |
May I try my hand at this? |
Hello Team, My name is SuperFranky, and I am excited to be participating in the first edition of ODBoost. I am a frontend and blockchain developer with over 3+ years of experience and have contributed to a variety of interesting projects in the Web3 space. My expertise in React, Next.js, Solidity, Cairo, responsive design, and an array of other programming languages makes me confident in delivering high-quality solutions. I have contributed to and hacked on several blockchains, including Base, Arbitrum, Scroll, Ethereum, Stellar, and StarkNet, which has deepened my understanding of blockchain ecosystems and development. I am passionate about contributing to open-source Web3 projects and committed to delivering exceptional results. Thank you for considering my application. |
To handle this issue, I would |
Is it okay if I tackle this? |
Please add a test about a custom error handler that could be used to invalidate an error by returning nil
adding a custom error handler allow to mess up things, because people may do that in their custom handler if you dont want to support it, the mechanism of error handling should be rewritten to forbid this behavior
Originally posted by @ccoVeille in #320 (comment)
The text was updated successfully, but these errors were encountered: