Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The custom error addition should handle edge cases #322

Open
ccoVeille opened this issue Dec 29, 2024 · 20 comments
Open

The custom error addition should handle edge cases #322

ccoVeille opened this issue Dec 29, 2024 · 20 comments
Labels
good first issue Good for newcomers OD Boost Issues for the OnlyDust event

Comments

@ccoVeille
Copy link
Collaborator

ccoVeille commented Dec 29, 2024

Please add a test about a custom error handler that could be used to invalidate an error by returning nil

adding a custom error handler allow to mess up things, because people may do that in their custom handler if you dont want to support it, the mechanism of error handling should be rewritten to forbid this behavior

Originally posted by @ccoVeille in #320 (comment)

@EwenQuim
Copy link
Member

Good ideas

@Elite-tch
Copy link

I'd love to give this a go.

@ekumamatthew
Copy link
Contributor

May I be assigned to this?

@olisaagbafor
Copy link

olisaagbafor commented Jan 13, 2025

@EwenQuim Can I take this issue?

@dylanhitt
Copy link
Collaborator

dylanhitt commented Jan 13, 2025

Anyone is welcome to take this as it's pretty wide open. I guess to be to close this we would need to test all the content-type options inputtabl for this scenario. Right now we only test application/json.

The best thing would be to add a table of content types here and test then. https://github.com/go-fuego/fuego/blob/main/serve_test.go#L637

Hope this helps!

@ryzen-xp
Copy link

@ryzen-xp
Copy link

Could I try solving this?

@EwenQuim EwenQuim added the OD Boost Issues for the OnlyDust event label Jan 20, 2025
@dylanhitt
Copy link
Collaborator

Hey @ryzen-xp feel free.

Some work had been started on this. Please see this comment for closable acceptance criteria. #322 (comment)

@chiscookeke11
Copy link

Could I take over this issue?

@0xprinc
Copy link

0xprinc commented Jan 22, 2025

Could I grab this task?

@Supa-mega
Copy link

Is it okay if I tackle this?

1 similar comment
@KinmatTech
Copy link

Is it okay if I tackle this?

@martinvibes
Copy link

Holla i'm Martin, I'm a frontend developer who enjoys building smooth applications to pixel perfect and engaging websites using JavaScript, typescript and frameworks(React, nextjs, tailwindcss etc.) and i have contributed to other projects that have been merged.
Am also experienced in working and writing smart contracts.
Kindly assign :)

@Michaelkingsdev
Copy link

May I be assigned to this?

@dylanhitt
Copy link
Collaborator

As stated before anyone is welcome to take this issue. Feel free to take the initiative!

😄

@abdegenius
Copy link

Let me try this one!

@ShantelPeters
Copy link

May I try my hand at this?

@FrankiePower
Copy link

Hello Team,

My name is SuperFranky, and I am excited to be participating in the first edition of ODBoost. I am a frontend and blockchain developer with over 3+ years of experience and have contributed to a variety of interesting projects in the Web3 space. My expertise in React, Next.js, Solidity, Cairo, responsive design, and an array of other programming languages makes me confident in delivering high-quality solutions.

I have contributed to and hacked on several blockchains, including Base, Arbitrum, Scroll, Ethereum, Stellar, and StarkNet, which has deepened my understanding of blockchain ecosystems and development.

I am passionate about contributing to open-source Web3 projects and committed to delivering exceptional results.

Thank you for considering my application.

@aniruddhaaps
Copy link

To handle this issue, I would
-Add a test case to simulate a custom error handler that returns nil, ensuring it does not invalidate errors inappropriately.
-If it's unsupported, I will rewrite the error handling mechanism to forbid nil returns in custom handlers.
-Then I would document the expected behavior for custom error handlers to guide users against misusing this functionality.

@Supa-mega
Copy link

Is it okay if I tackle this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers OD Boost Issues for the OnlyDust event
Projects
None yet
Development

No branches or pull requests