Clarification needed on term's classification and designation's normative_status

[skalee]

Following pseudo YAML illustrates the problem, only relevant fields included:

eng:
  terms:
    - type: expression
      normative_status: (always "preferred")
      designation: (taken from TERM column)
    - type: expression
      normative_status: (taken from SYNONYM1STATUS column)
      designation: (taken from SYNONYM1 column)
    - type: expression
      normative_status: (taken from SYNONYM3STATUS column)
      designation: (taken from SYNONYM2 column)
    - type: expression
      normative_status: (taken from SYNONYM3STATUS column)
      designation: (taken from SYNONYM3 column)
    - type: symbol
      designation: (taken from SYMBOLE column)
  classification: (taken from SYNONYM1STATUS column)
  entry_status: (taken from STATUS column, in fact always "valid")

(Only relevant fields are included. Of course some spreadsheet columns may contain more than one designation, but let's skip that for simplicity.)

What I want to say is that localized concept's classification and normative_status for the 2nd term are taken from the same SYNONYM1STATUS column, and that smells like a bug. There is no TERMSTATUS column or anything like that in the spreadsheet. There is STATUS column, but it always says "Standard" and is used for entry_status:

iev-data/lib/iev/termbase/term_builder.rb

Lines 370 to 375 in 22a7561

	def extract_entry_status
	case find_value_for("STATUS").downcase
	when "standard" then "valid"
	else nil
	end
	end

---

cc @ronaldtse

[ronaldtse]

@HassanAkbar can you help address this issue? Thanks!

[HassanAkbar]

@ronaldtse What should we do in this case? There is no column in the sheet for classification and currently, the classification value is obtained from the SYNONYM1STATUS column which is also used for the normative_status value.

Also currently there is no other value except Standard in the STATUS column and it is used for the entry_status value.

[ronaldtse]

@HassanAkbar the full dataset (that contains historic information) will have other values in the STATUS column. Is the point to make these status values configurable per dataset?

[HassanAkbar]

@ronaldtse There are actually 2 points

1. There is no column in the sheet for classification and currently, the classification value is obtained from the SYNONYM1STATUS column which is also used for the normative_status value. According to skalee this seems like a bug or this might cause bugs in the future because the classification is for overall concept while SYNONYM1STATUS is for synonym 1.
2. Also currently there is no other value except Standard in the STATUS column and it is used for the entry_status value. (You have answered this question in the last comment)