[Bug]: 404 with GraphQL endpoint in Github Enterprise Server

[mhaas]

GitHub CLI Version

2.63.2

gh-skyline Version

0.0.4

What Operating System are you seeing the problem on?

macOS

What happened?

I am trying to generate my Skyline against a Github Enterprise Service instance.

When running gh skyline as it, it attempts to connect to github.com:

➜ gh skyline
Error: [NETWORK] failed to initialize GitHub client: failed to create REST client: authentication token not found for host github.com

Using GH_HOST, the cli is using the wrong GraphQL endpoint:

➜ GH_HOST=github.XXX.YYY gh skyline
Error: failed to fetch contributions: [GRAPHQL] failed to fetch contributions: HTTP 404: Not Found (https://github.XXX.YYY/api/v3/graphql)

The correct GraphQL URL would be https://github.XXX.YYY/api/graphql. This is also encoded by the corresponding logic in graphQLEndpoint.

I would appear to be correctly authenticated, with the "active" instance being set to the GHE instance:

➜ gh auth status
github.XXX.YYY
  ✓ Logged in to github.XXX.YYY account ZZZZZZZ (keyring)
  - Active account: true
  - Git operations protocol: https
  - Token: gho_************************************
  - Token scopes: 'gist', 'read:org', 'repo', 'workflow'

github.AAAA.BBB.CCC # other GHE instance
  ✓ Logged in to github.AAAA.BBB.CCC account ZZZZZZZ (keyring)
  - Active account: true
  - Git operations protocol: https
  - Token: gho_************************************
  - Token scopes: 'gist', 'read:org', 'repo', 'workflow'

Appreciate your support, the X1C needs a break from churning out multiboard parts :)

[chrisreddington]

Thanks @mhaas, I've started taking a look at this one. Your link to the graphQLEndpoint in go-gh was super helpful. I think this is happening because I've implemented some parts in REST vs GraphQL and have been inconsistent in the approach.

I'll be making some tweaks to try and separate out some of the concerns a little more, so I'll keep you posted on progress 😄 Thank you for the interest and raising this 🙏

[mhaas]

Thanks, happy to test if you got a PR as well :)

[chrisreddington]

Thanks, happy to test if you got a PR as well :)

Thank you @mhaas! Here's the first pass at the PR, though I'd like to go back and clean up a few bits before merging it in ☺️

[chrisreddington]

Hey @mhaas! Just a note to say that I've merged that PR ☝ into main, but it's not yet made its way into a new release of the CLI.

If you wanted to run a local version of main and run the ./rebuild.sh script (which uninstalls any existing Skyline extension and installs the one from the local repo), then you would be able to test it there 😄