Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join Condition (on clause) not working as given in the docs #53

Open
faiqahsan opened this issue May 16, 2024 · 3 comments
Open

Join Condition (on clause) not working as given in the docs #53

faiqahsan opened this issue May 16, 2024 · 3 comments

Comments

@faiqahsan
Copy link

faiqahsan commented May 16, 2024

As given in the docs when sending the query string like
http://localhost:3100/Customers?join=facilities||id,status||on[0]=facilities.status||$eq||Archived&filter[0]=id||$eq||4 the join condition gets omitted because the join key is not intercepted correctly, key value pair is coming as
key= join=facilities||id,status||on
value= facilities.status||$eq||Archived

But we actually need
key= join
value= facilities||id,status||on[0]=facilities.status||$eq||Archived

@faiqahsan
Copy link
Author

faiqahsan commented May 16, 2024

Only fix is to just add brackets to the join clause like this.
http://localhost:3100/Customers?join[]=facilities||id,status||on[0]=facilities.status||$eq||Archived&filter[0]=id||$eq||4 but i believe this should be updated in the docs as well.
@zaro

@afilp
Copy link

afilp commented Jun 1, 2024

Can you please add a PR for the docs to be updated accordingly? Thanks!

Also @@ZaidMaslouhi, FYI.

@ZaidMaslouhi
Copy link

@zaro solved in PR #67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants