Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit retries block main thread: Drop commits instead? #415

Open
untitaker opened this issue Dec 23, 2024 · 0 comments
Open

Commit retries block main thread: Drop commits instead? #415

untitaker opened this issue Dec 23, 2024 · 0 comments

Comments

@untitaker
Copy link
Member

untitaker commented Dec 23, 2024

our default commit retry policy is retrying the commit up to 3 times with 1 second delay. during those 1-3 seconds we are blocking the main thread, potentially creating backlogs (not just in terms of consumer lag, which is unavoidable since we can't commit, but also application-level ingestion latency). it would be more appropriate to either drop the commit (if we know another commit will come in anyway), or defer committing to a background thread.

related: #414

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant