Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google Spreadsheets worksheet by title cleanup/refactor #6409

Open
guidopetri opened this issue Aug 31, 2023 · 5 comments · May be fixed by #6977
Open

Google Spreadsheets worksheet by title cleanup/refactor #6409

guidopetri opened this issue Aug 31, 2023 · 5 comments · May be fixed by #6977
Assignees
@guidopetri
Labels
enhancement good first issue A fairly simple issue suitable for people learning Redash development

Comments

@guidopetri
Copy link
Contributor

In #5334 , I left a few comments about future work on the "fetch worksheet by title" functionality for the google spreadsheets query runner. We should address those, namely:

  • don't use mixed-type variables
  • allow for non-quoted worksheet titles (single word)
  • verify 0/1 indexing of worksheet numbers, and add comment if it differs
@guidopetri guidopetri added enhancement good first issue A fairly simple issue suitable for people learning Redash development labels Aug 31, 2023
@guidopetri guidopetri self-assigned this Aug 31, 2023
@TanyaKansal
Copy link

can I work on this issue?

@guidopetri
Copy link
Contributor Author

@TanyaKansal absolutely! Feel free to submit a PR and tag me in it when it's ready for review :)

@immortalcodes
Copy link

@guidopetri I didn't quite understand the 3rd point , btw for other 2 please have a look master...immortalcodes:redash:google-sheet-singleword-title

@immortalcodes immortalcodes mentioned this issue Oct 9, 2023
Open
10 tasks
@getredash getredash deleted a comment from immortalcodes Oct 16, 2023
@justinclift
Copy link
Member

Note - removed duplicated comment above. 😉

This was referenced May 17, 2024
Open
Closed
@DhanushA1307
Copy link

Hi. I am new and would like to contribute to this issue @guidopetri

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guidopetri guidopetri

Labels
enhancement good first issue A fairly simple issue suitable for people learning Redash development
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Enhance] enhance fetch worksheet by title parsing, improve code readability mdirfan40/redash
6 participants
@justinclift @guidopetri @TanyaKansal @DhanushA1307 @immortalcodes and others