Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

confusing behavoiur when pass non boolean to stats/binary-measures #33

Open
behrica opened this issue Sep 28, 2024 · 2 comments
Open

confusing behavoiur when pass non boolean to stats/binary-measures #33

behrica opened this issue Sep 28, 2024 · 2 comments

Comments

@behrica
Copy link
Contributor

behrica commented Sep 28, 2024

Passing seq such as
[0 1 0 1 0 0]
[1 1 1 1 1 1]

to stats/binary-measures

is handled as seq being equal, so for example giving accuracy of 1

It took me very long to discover that it requires true/false.

I suggest to fail fast in this case.

@genmeblog
Copy link
Contributor

Maybe it's not clear in the documentation but you can pass a third argument which will be used to decode your encoding.
It can be a list of truths or predicate, so in your case it's a [1] or #{1} or even a map {1 true 0 false}.

I think I can add reasoning about numerical encoding where 1 is always true and other values will be treated as false.

@genmeblog
Copy link
Contributor

Will be fixed in the next alpha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants