Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full Vue Components for Workflow Input Definitions #19303

Open
jmchilton opened this issue Dec 10, 2024 · 0 comments
Open

Full Vue Components for Workflow Input Definitions #19303

jmchilton opened this issue Dec 10, 2024 · 0 comments

Comments

@jmchilton
Copy link
Member

Right now we're relying on the tool form which has a set of limitations that is a real headache every time we want to implement a new feature. We cannot validate the collection type selector properly, constructing the datatype selection on the backend is hacky and doesn't allow datatypes to be selected, we have to work very hard to make sure the database doesn't get populated with tool formisms and the <tool form> <-> <database/gxformat2 representation of inputs> code for parameter inputs is getting very complicated (https://github.com/galaxyproject/galaxy/blob/release_24.2/lib/galaxy/workflow/modules.py#L1203) and it is very awkward backend complication to render frontend things properly.

The last two times I tried to fix this situation the pieces on the frontend were very locked into tool form stuff, however with everything sort of Vue-ified now it looks really approachable to swap these pieces out. My initial outlines of attempts are here in the sample sheets branch. I'm going to start with a form for dataset input collections because #19085 is blocked on this - hopefully the components can be reused for data inputs though and we can someday replace the crazy form building for parameter inputs once we're done with the collection inputs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant