Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow: "Changes" list of actions should highlight unresolved items that are preventing a save #19266

Open
jennaj opened this issue Dec 5, 2024 · 2 comments
Assignees
Labels
release-testing-24.2 Issues stemming from 24.2 release testing process and PRs to address them
Milestone

Comments

@jennaj
Copy link
Member

jennaj commented Dec 5, 2024

Describe the bug
Saving a workflow can be blocked by unresolved items on the workflow canvas.

If the user did something that is captured in the changes listing that is part of that save blocking, and the canvas item is in red with a warning, that action in the change list should also be highlighted in red.

Love the Changes redo/undo overall! And also like the save blocking for unstable changes. These are just some ideas to make the usage easier!

Galaxy Version and/or server at which you observed the bug
This Galaxy server version is 25.0.dev0, and the web client was built on Wednesday Dec 4th 10:32:30 2024 GMT-8 .

Browser and Operating System
Operating System: Windows, Linux, macOS
Browser: Firefox, Chrome, Chrome-based, Safari

To Reproduce
Steps to reproduce the behavior:

  1. Go to a workflow in the editor
  2. Do something that prevents a save, such as adding a sub-workflow that is not owned (example).
  3. Try to save the workflow, get the message about the problem.
  4. Go to your changes listing -- good luck! Which item is the problematic item isn't clear.
  5. Presumably we know which that is, yes? Highlighting it would be great. Even better, also add that exact item to the warning, and tell the user to look under their Changes. This is how tool warnings appear during workflow imports -- maybe can reuse that same view here?
  6. Any other problematic items that were already resolved by the user and not blocking the save should not be highlighted.

Expected behavior
Change items blocking a save are clearly highlighted so the user can find and undo those.

Screenshots

workflow-blocked-save1

workflow-blocked-save2

Additional context
Add any other context about the problem here.

@jennaj jennaj added the release-testing-24.2 Issues stemming from 24.2 release testing process and PRs to address them label Dec 5, 2024
@ElectronicBlueberry ElectronicBlueberry self-assigned this Dec 6, 2024
@mvdbeek
Copy link
Member

mvdbeek commented Dec 10, 2024

You should not be able to add someone else's workflow here, if other people's workflows are listed in an admin's workflow acitivity that would be quite the bug (independently of highlight changes that are potentially at fault).

@jennaj
Copy link
Member Author

jennaj commented Dec 10, 2024

I was just in a regular non-admin account. :)

@jdavcs jdavcs added this to the 24.2 milestone Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-testing-24.2 Issues stemming from 24.2 release testing process and PRs to address them
Projects
None yet
Development

No branches or pull requests

4 participants