r.includes is not a function

[CodeShadower]

Which version of floccus are you using?

5.4.1

How many bookmarks do you have, roughly?

800

Are you using other means to sync bookmarks in parallel to floccus?

No

Sync method

WebDAV

Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.

Android 14

Which version of Nextcloud Bookmarks are you using? (if relevant)

n/a

Which version of Nextcloud? (if relevant)

n/a

What kind of WebDAV server are you using? (if relevant)

https://xxxxxx.connect.kdrive.infomaniak.com

Describe the Bug

Error message at the top of the window: "r.includes is not a function"

Expected Behavior

My bookmarks should sync as they did before (last time is unknown).

To Reproduce

1. Delete Floccus cache and data
2. Uninstall and reinstall Floccus Github apk or F-Droid App (same result)
3. Create new profile for kDrive WebDAV sync (importing previous profile gives the same result)

PS: I went back installing untill v 5.0.11, but still got the error. v5.0.10 doesn't start anymore on my phone.

Debug log provided

• I have provided a debug log file

[github-actions]

Hello 👋

Thank you for taking the time to open this issue with floccus. I know it's frustrating when software
causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at
and if possible solved.
I'm Marcel and I created floccus a few years ago, maintaining it ever since. I currently work for Nextcloud
which leaves me with less time for side projects like this one than I used to have.
I still try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until I get to it.
Until then, please be patient.
Note also that GitHub is a place where people meet to make software better together. Nobody here is under any obligation
to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can
collaborate to make this software better. For everyone.
Thus, if you can, you could also have a look at other issues to see whether you can help other people with your knowledge
and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and
try to fix the odd bug yourself. Everyone will be thankful for extra helping hands!
To continue the development and maintenance of this project in a sustainable way it is expected that you donate to the project when opening a ticket,
if you're not a donor already. You can find donation options at https://floccus.org/donate/. Thank you!

One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the Nextcloud forum,
to twitter or somewhere else. But this is a technical issue tracker, so please make sure to
focus on the tech and keep your opinions to yourself.

I look forward to working with you on this issue
Cheers 💙

[CodeShadower]

Donation just made. 😉

[marcelklehr]

Thank you! The error seems to stem from the encryption module. Could it be that you have set the wrong encryption password? (Ideally, there should be a better error message, of course, though)

[CodeShadower]

I exported my profile from my laptop in which I use Floccus with Firefox, Brave and Vivaldi, so this should work, correct?

[marcelklehr]

It could be that the file is corrupted somehow, then. Can you try deleting it and doing a push sync to create it again?

[CodeShadower]

I did a push sync from my laptop in Brave and now when I import the profile in Floccus App Android I get the following new error:

[marcelklehr]

Can you try with the latest release? It's still in beta on Google Play, though, so you'll have to join the beta program if you use Google play to install

[CodeShadower]

Thank you Marcel, I'll install it and report back. 👍🏻 13 janv. 2025 18:09:28 Marcel Klehr ***@***.***>:

…

Can you try with the latest release? It's still in beta on Google Play, though, so you'll have to join the beta program if you use Google play to install — Reply to this email directly, view it on GitHub[#1812 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AC5FBHJEGHGI2TYJBSYJDVT2KPXMNAVCNFSM6AAAAABUTDUB4WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOBXGY4TOMBUG4]. You are receiving this because you authored the thread. [Image de pistage][https://github.com/notifications/beacon/AC5FBHJVQBAT3REL7YRBKDT2KPXMNA5CNFSM6AAAAABUTDUB4WWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTU2HUPZO.gif]

[CodeShadower]

Unfortunately Playstore says that the beta program is complete: [Image] 13 janv. 2025 18:09:28 Marcel Klehr ***@***.***>:

…

Can you try with the latest release? It's still in beta on Google Play, though, so you'll have to join the beta program if you use Google play to install — Reply to this email directly, view it on GitHub[#1812 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AC5FBHJEGHGI2TYJBSYJDVT2KPXMNAVCNFSM6AAAAABUTDUB4WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOBXGY4TOMBUG4]. You are receiving this because you authored the thread. [Image de pistage][https://github.com/notifications/beacon/AC5FBHJVQBAT3REL7YRBKDT2KPXMNA5CNFSM6AAAAABUTDUB4WWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTU2HUPZO.gif]

[marcelklehr]

Ah, I see, it doesn't allow more people to join. Can you try installing the APK from here? https://github.com/floccusaddon/floccus/releases/tag/v5.4.2

[CodeShadower]

Unfortunately, there is no change: I deleted the profile, uninstalled the app, reinstalled the new version, imported the profile (working on my laptops). [Image] 13 janv. 2025 21:40:34 Marcel Klehr ***@***.***>:

Ah, I see, it doesn't allow more people to join. Can you try installing the APK from here? https://github.com/floccusaddon/floccus/releases/tag/v5.4.2 — Reply to this email directly, view it on GitHub[#1812 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AC5FBHNKUMFKKGZZMMHE4OL2KQQEBAVCNFSM6AAAAABUTDUB4WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOBYGE2DSOJRHE]. You are receiving this because you authored the thread. [Image de pistage][https://github.com/notifications/beacon/AC5FBHLECB5COS3HQHVBWPT2KQQEBA5CNFSM6AAAAABUTDUB4WWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTU2IQEJ6.gif]

2025-01-13T20:45:54.640Z Starting sync process for account ***@***.***@141963.connect.kdrive.infomaniak.com 2025-01-13T20:45:54.649Z onSyncStart: begin 2025-01-13T20:45:55.221Z onSyncFail 2025-01-13T20:45:55.221Z Freeing lock: ###server###xBookmarks/bookmarks.xbel.lock 2025-01-13T20:45:55.299Z Syncing failed with r.includes is not a function 2025-01-13T20:45:55.305Z onSyncFail 2025-01-13T20:45:55.306Z Freeing lock: ###server###xBookmarks/bookmarks.xbel.lock

[marcelklehr]

Mmmh, this is strange. It seems that the app does not receive any data from the server, even though it works fine on the desktop for you 🤔

[CodeShadower]

Anything I could provide to help you narrow down the cause? 15 janv. 2025 14:17:02 Marcel Klehr ***@***.***>:

…

Mmmh, this is strange. It seems that the app does not receive any data from the server, even though it works fine on the desktop for you 🤔 — Reply to this email directly, view it on GitHub[#1812 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AC5FBHJJCKSTFLBH6PFPUGL2KZNU3AVCNFSM6AAAAABUTDUB4WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJSHAZTGNJVG4]. You are receiving this because you authored the thread. [Image de pistage][https://github.com/notifications/beacon/AC5FBHKRMMIMFW2EPHI5QLL2KZNU3A5CNFSM6AAAAABUTDUB4WWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTU2ROABK.gif]

[marcelklehr]

Can you perhaps try to access the android logs of the app?

[CodeShadower]

How do I do that? PS: My smartphone is not rooted. 15 janv. 2025 17:03:45 Marcel Klehr ***@***.***>:

…

Can you perhaps try to access the android logs of the app? — Reply to this email directly, view it on GitHub[#1812 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AC5FBHKA4M6LYX76FJHCOYD2K2BEVAVCNFSM6AAAAABUTDUB4WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJTGMZDKOJRGY]. You are receiving this because you authored the thread. [Image de pistage][https://github.com/notifications/beacon/AC5FBHOYXROLFDZUUZXPRRD2K2BEVA5CNFSM6AAAAABUTDUB4WWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTU2SMBVY.gif]

[marcelklehr]

You will need to install Android Studio on your computer, connect the phone to your computer, enable developer mode on your phone and then opening logcat in android studio to see the logs of your phone. If you are not a developer I think it's unlikely you will get this to work :S

[CodeShadower]

Thank you Marcel, fortunately, I'm a computer science engineer. 😉 

Will the attached file help?

[marcelklehr]

Awesome :)
That's exactly what I wanted, but it also doesn't contain more info, sadly.

Note that it does contain your passphrase in cleartext and password as base64, though :S

[CodeShadower]

Damn, I was convinced that I obfuscated sensitive info...

[marcelklehr]

Can you perhaps try using a different webdav server? Just to check?

[CodeShadower]

Thank you for your suggestion, but unfortunately I use no other WebDAV server... So I made another test: creating a new folder and a new bookmarks file succeeded. Therefore, I fear that there is an issue with the original bookmarks file... Strange though that it can be handled on my PCs and laptops, but not on my Android. Is there some kind of limitation in Floccus? My file is about 800kB. Following that thought, I recovered an older version of my bookmarks file which is about 500kB and this time it worked. I narrowed it down to two files with a few kB difference. So, my question is: how can I pinpoint the issue with my original bookmarks file? I suppose that the way to proceed would be to take both bookmark files back on my laptop and from there import the first one, switch the backup format from xbel to html and then compare the difference between both files. What's your opinion about it? PS: Thank you, I changed my password. 16 janv. 2025 16:52:34 Marcel Klehr ***@***.***>:

…

Can you perhaps try using a different webdav server? Just to check? — Reply to this email directly, view it on GitHub[#1812 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AC5FBHOXLPZ4KSKN4HK367T2K7IUBAVCNFSM6AAAAABUTDUB4WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJWGA4DQMBRGY]. You are receiving this because you authored the thread. [Image de pistage][https://github.com/notifications/beacon/AC5FBHOSVVTJRAWKXX3Y7TD2K7IUBA5CNFSM6AAAAABUTDUB4WWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTU2XUUNA.gif]

[marcelklehr]

I suppose that the way to proceed would be to take both bookmark files back on my laptop and from there import the first one, switch the backup format from xbel to html and then compare the difference between both files.

I don't quite follow. What would switching the format achieve?

[CodeShadower]

Isn't the xbel format binary, so I can't compare two files whereas html is text, thus really comparable, no? 17 janv. 2025 14:37:11 Marcel Klehr ***@***.***>:

…

I suppose that the way to proceed would be to take both bookmark files back on my laptop and from there import the first one, switch the backup format from xbel to html and then compare the difference between both files. I don't quite follow. What would switching the format achieve? — Reply to this email directly, view it on GitHub[#1812 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AC5FBHIFLLGQ27XXMXIIBVT2LEBQLAVCNFSM6AAAAABUTDUB4WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJYGM4DKMRTG4]. You are receiving this because you authored the thread. [Image de pistage][https://github.com/notifications/beacon/AC5FBHOIT6AOBM3W2EIBSBD2LEBQLA5CNFSM6AAAAABUTDUB4WWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTU24A3FK.gif]

[marcelklehr]

XBEL is XML :)

[CodeShadower]

Understood: I got caught, beacause I enabled encryption.

So, I finally disabled the encryption and there is no error message anymore.

From my perspective, the case can be closed, but there is definitely an issue with the encyptio module.

[marcelklehr]

So, I finally disabled the encryption and there is no error message anymore.

Well, that's not a solution for me, the encryption needs to work

Can you send the encrypted file to me via email, perhaps?

[CodeShadower]

Yes, where can I send it so it's not going to be published on github? 19 janv. 2025 10:02:31 Marcel Klehr ***@***.***>:

…

So, I finally disabled the encryption and there is no error message anymore. Well, that's not a solution for me, the encryption needs to work Can you send the encrypted file to me via email, perhaps? — Reply to this email directly, view it on GitHub[#1812 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AC5FBHLEQRBMLEZFWDCMLQT2LNS2LAVCNFSM6AAAAABUTDUB4WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBQG43DOMZTGE]. You are receiving this because you authored the thread. [Image de pistage][https://github.com/notifications/beacon/AC5FBHPVCDAOO2T5XVLCQ4D2LNS2LA5CNFSM6AAAAABUTDUB4WWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTU3ASHWG.gif]

[marcelklehr]

:) [email protected] is my email

[CodeShadower]

It's going to take some time as I want to filter my bookmarks. I'll get back to you. 19 janv. 2025 10:37:54 Marcel Klehr ***@***.***>:

…

:) ***@***.*** is my email — Reply to this email directly, view it on GitHub[#1812 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AC5FBHMBLDC43AGE36EATYD2LNW7DAVCNFSM6AAAAABUTDUB4WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBQG44DANRSGU]. You are receiving this because you authored the thread. [Image de pistage][https://github.com/notifications/beacon/AC5FBHJ2B5N4U3G5DT5EQSD2LNW7DA5CNFSM6AAAAABUTDUB4WWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTU3ATBVC.gif]

[marcelklehr]

I don't need the cleartext version, though. Just the encrypted version.

[CodeShadower]

Email with encrypted bookmarks file sent to your gmx address.

[marcelklehr]

Mmh, even with the same file I don't get the same error.

So I made another test: creating a new folder and a new bookmarks file succeeded.

I wonder how this is different from deleting the original file and doing a push sync ... 🤔

[marcelklehr]

I believe I did find the reason for why the error message is not a nice message, so in the future you should get a nice "file is corrupt" message, but the reason for the corruption is beyond me at the moment.

[marcelklehr]

I encourage you to keep using the encryption, but I understand if you don't. I'm closing this for now.

[CodeShadower]

Thank you anyway Marcel for following up on this. As you can guess, it makes no sense for me, with this error, to use encryption otherwise I can't sync my bookmarks from my PCs to my smartphone and vice versa. It's not a big deal as it's only for bookmarks and I'm using the best Swiss cloud infrastructure respecting privacy, the environment and with multiple certifications. 😃 I'll try to re-encrypt the file and check the result, but for now I'll push the troubleshooting PAUSE mode. 😉 Thank you for your great and really useful add-on allowing modularity and decoupling essential data services! ❤️. 22 janv. 2025 08:52:26 Marcel Klehr ***@***.***>:

…

I encourage you to keep using the encryption, but I understand if you don't. I'm closing this for now. — Reply to this email directly, view it on GitHub[#1812 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AC5FBHLTRQG7JEOD2HTHDVD2L5E3RAVCNFSM6AAAAABUTDUB4WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBWGUYTSNBRHE]. You are receiving this because you authored the thread. [Image de pistage][https://github.com/notifications/beacon/AC5FBHMQQ4ZUVHL6I6BRTQD2L5E3RA5CNFSM6AAAAABUTDUB4WWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTU3LRKHW.gif]