Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markers not showing / updating / deleting on low-use servers or when disconnected #76

Open
CoryFoy opened this issue Jan 8, 2025 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@CoryFoy
Copy link
Member

CoryFoy commented Jan 8, 2025

Describe the bug
When adding / updating / deleting a marker when either connected to a low-use TAK Server or not connected at all, markers may not initially update until other actions are taken (such as adding another marker) even though the haptic feedback indicates the action was taken.

To Reproduce
Steps to reproduce the behavior:

  1. Disconnect from all TAK Servers
  2. Long-press on the map

Expected behavior
Expect to see a marker show up. But it doesn't (until you long-press on another part of the map)

Smartphone (please complete the following information):

  • Version: [e.g. 22] 1.1.76
  • App Store or TestFlight?: App Store

Additional context
The issue is that the marker is being created, but the notification system hasn't merged it from the background context into the main context by the time the map tries to query for it. Effectively this is a race condition. It doesn't matter on a busy server because enough actions are happening that it will get picked up the next time markers get updated. But the fix is simply to perform add / update / delete actions of markers on the main viewcontext since the user is interacting with the map at that point.

@CoryFoy CoryFoy added the bug Something isn't working label Jan 8, 2025
@CoryFoy CoryFoy added this to the 1.2 App Store Release milestone Jan 8, 2025
@CoryFoy CoryFoy self-assigned this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant