-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should this webui work for both L1 and L2? #4
Comments
I agree with your proposal at the high level 👍🏻
I think this is slightly more complex. We will be discussing in filecoin-saturn/L2-node#25 what to display in the dashboard, so far we have the following items:
I think it's reasonable to assume that 1) both L1 and L2 nodes can provide these four stats and 2) both L1 and L2 operators will be interested in all four stats, therefore it makes sense to implement a single shared UI.
Maybe we can implement the UI as data driven? Depending on what data fields are returned by the L1/L2 node, we can render or hide different components of the UI? Anyhow, I think this is far in the future and we can defer the decision until we better understand the differences in requirements for L1 and L2 UI. Should we rename this repo to https://github.com/filecoin-project/saturn-webui then? |
FWIW, in the current design, the Station Electron app is loading saturn-l2-webui via explicit URL at localhost. |
Yep, we'll figure it out. Let's commit to a single repo and start reaping the benefits immediately. I've renamed it. |
The high level requirements of the L1 and L2 dashboards are the same: Input a FIL address and receive a dashboard.
If this project worked for both L1 and L2, it would save a significant amount of dev time compared to two different projects.
What can be shared:
What will differ:
Sharing the UI is key. The dashboards will have a consistent look and devs won't have to coordinate design across multiple repos. Stay DRY folks.
The requirements for L1/L2 will eventually diverge. I don't foresee this being a huge complication, but as an escape hatch we can always split the project into 3 folders (
L1/
,L2/
shared/
). This way we can easily continue sharing UI code.Thoughts?
The text was updated successfully, but these errors were encountered: