Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin should not modify the build environment #8

Open
britter opened this issue Nov 14, 2023 · 0 comments
Open

Plugin should not modify the build environment #8

britter opened this issue Nov 14, 2023 · 0 comments

Comments

@britter
Copy link
Contributor

britter commented Nov 14, 2023

This plugin has a sophisticated system for making the shellcheck binary available by calling various package managers. This modifies the build environment by adding a binary into the PATH. This is a surprising side-effect. I want my build to be contained in the project directory and not tamper with my system.

Instead of using package managers to install shellcheck, this plugin should instead add a custom Ivy repository to the build and then define a dependency on the shellcheck GitHub release. It has to detect the current OS and system architecture to select the correct variant. An artifact transform can be used to untar the binary. The command line for running shellcheck can then be constructed using the unpack location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant