Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GXF Reader Implementation #538

Open
ThomasMGeo opened this issue Oct 30, 2024 · 6 comments
Open

GXF Reader Implementation #538

ThomasMGeo opened this issue Oct 30, 2024 · 6 comments
Labels
enhancement Idea or request for a new feature

Comments

@ThomasMGeo
Copy link

ThomasMGeo commented Oct 30, 2024

Description of the desired feature:

GXF is another Geosoft (now seequent) ASCII file format. It is found sometimes with USGS data releases like here. There is also this gist that I have found.

Are you willing to help implement and maintain this feature?
Yes! I currently have functions that work for my needs, but I think this is complimentary to the grd file reader, and should be included in Harmonica. I am happy to do a PR, or help as needed.

One design thing I am concerned about is going from a GXF directly to xarray. I had to mess with the specific examples I had by hand to 'get it right' and wondering if that is best left to the user?

@ThomasMGeo ThomasMGeo added the enhancement Idea or request for a new feature label Oct 30, 2024
@ThomasMGeo
Copy link
Author

Here is my gist with code.

@ThomasMGeo
Copy link
Author

@RichardScottOZ do you have a python GXF reader hiding somewhere?

@leouieda
Copy link
Member

@ThomasMGeo seems like a great thing to have in Harmonica! I don’t think I understand your reservation with going to xarray. From your gist, it seems like it would be easy to make the metadata CF-compliant and add it to a DataArray or Dataset. The main advantage is that everything else in Harmonica works with xarray and saving to another format like netCDF or Zarr is also trivial.

A PR would be very welcome! Even if just to get things started.

@ThomasMGeo
Copy link
Author

I will make it a data array in the PR, to just get it going. Thanks!

@leouieda
Copy link
Member

Would you be able to generate a small grid in that format so we can use for unit testing? It would have to be small so we can store it directly in the repository (like <1Mb).

@RichardScottOZ
Copy link
Contributor

@RichardScottOZ do you have a python GXF reader hiding somewhere?

No, sorry! Need a GDB reader though. Bound to have a few of the above in the archives I imagine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Idea or request for a new feature
Projects
None yet
Development

No branches or pull requests

3 participants