-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compute quickly the byte lengths without look-ups #12
Comments
The length is 1 + the rightmost index in the decoding shuffle, which is within the last four entries. |
|
It is definitely susceptible to various bithacks. I used the permutation table since it's available, but the 2-bit fields could also be summed in a few instructions. mod15 compiles to a multiply and some shifts and subtracts, so it may be decomposable into fewer instructions in this context. Generally I would spread the bitfields out and use a multiply to sum them into something like the most significant byte; that's what I do in the compressor when I have the 2-bit fields already spread out. Your method of multiplying by 0x401 and masking looks promising -- they're far enough apart to sum into a nybble at that point. Multiplying by (1<<28)|(1<<24)|(1<<16)|(1<<12) should drop them on top of each other in the high nybble, if I've got those shifts right. |
I ran some numbers on my blog: Bit hacking versus memoization: a Stream VByte example. |
@lemire @aqrit I started a branch to see if precomputing byte lengths 8-at-a-time and prefix summing would speed up the decode loop. The pointer arithmetic in each decode_avx seemed like a barrier to ILP, and this modification makes it possible to dispatch the 8 decode_avx calls independently. However it has proved slower for the two methods I've tried (scalar shift/mask/add and a pshufb LUT, both similar to the blog article). I suspect the pshufb's are already single-threaded (there is only one port for them, I believe), and the length processing is not the critical path. |
@KWillets suggestion: could eventually become: If the literal data bytes get loaded at the high-end of the xmmword... then the lowest byte of the shuffle mask will also be the number of unused bytes in the data xmmword |
The length value could broken into bits and deposited into the sign bits of the byte shuffle table. I used this for "0124" decoding in |
Some look-ups could be efficiently replaced by fast instructions such as a
pdep
followed by a multiplication and a shift. It is unlikely to be generally faster than a look-up, but it might be worth exploring.The text was updated successfully, but these errors were encountered: