Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does the Triangulator have learnable parameters during training? #47

Open
OasisYang opened this issue Aug 7, 2024 · 1 comment
Open

Comments

@OasisYang
Copy link

Hi, thanks for releasing this great work! I've been examining your excellent work and have a question about the Triangulator.

I noticed it doesn't have any learnable parameters. Is this designed specifically for inference (given that the current inference process uses COLMAP bundle adjustment rather than a differentiable version)? If I were to fine-tune vggSfM on custom data, would I need to implement and train a Triangulator module with learnable parameters as described in your paper?

I appreciate your time and look forward to your response. Thanks!

@jytime
Copy link
Contributor

jytime commented Aug 8, 2024

Hi @OasisYang ,

Yes, the triangulator had learnable parameters when we trained our model, as detailed in our paper. However, in our release version, we switched to a formula-based triangulator. We made this change because the deep (learned) triangulator exhibited some weird behaviors with out-of-domain data, likely due to insufficient training on large-scale data. To simplify inference for all users, we temporarily removed the deep triangulator.

We plan to reintroduce the deep triangulator in VGGSfM version 2.1. Now, if you want to fine-tune our model, the simplest approach is to just fine-tune the camera predictor and tracker. This should yield reasonable performance due to the good initilization from our pretrained weights.

Best,
Jianyuan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants