Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The scale of timesteps in the text modeling examples #17

Open
realfolkcode opened this issue Dec 16, 2024 · 1 comment
Open

The scale of timesteps in the text modeling examples #17

realfolkcode opened this issue Dec 16, 2024 · 1 comment

Comments

@realfolkcode
Copy link

Hi! Really enjoying the code and the paper. These are the most comprehensive resources on flow matching.

I noticed that the text modeling example might contain a subpar encoding of timesteps. In short, it uses the default max_period parameter from the GLIDE repository, which is a diffusion model with discrete timesteps in the range {0, 1, 2, ...}. However, as I understand correctly, in your example, all timesteps are sampled from the [0, 1] time horizon. See the similar issue that I've opened in the SiT repository. I think the most elegant solution is to rescale the timesteps similar to how Flux handles them.

Let me know if I am misunderstanding something, as I am just on my way of learning the flow matching framework.

@itaigat
Copy link
Contributor

itaigat commented Dec 18, 2024

Thank you! we were not aware of this, we are experimenting now with time range [0,1] and period of 0.001 and 0.005. We will update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants