Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ssh signing] support custom signing program #2188

Open
seanaye opened this issue Apr 15, 2024 · 4 comments · May be fixed by #2198 or #2464
Open

[ssh signing] support custom signing program #2188

seanaye opened this issue Apr 15, 2024 · 4 comments · May be fixed by #2198 or #2464
Labels
enhancement New feature or request

Comments

@seanaye
Copy link

seanaye commented Apr 15, 2024

Describe the bug
When performing a commit I get the error
sign builder error: Failed to retrieve 'user.signingkey' from the git configuration: Currently, we only support a pair of ssh key in disk.

This is likely because of my git configuration for commit signing.

To Reproduce
Steps to reproduce the behavior:

  1. Add the following to your ~/.gitconfig
[user]
...

[gpg]
	format = ssh
[gpg "ssh"]
	program = /Applications/1Password.app/Contents/MacOS/op-ssh-sign
[commit]
	gpgsign = true
[push]
	autoSetupRemote = true
  1. try to perform a commit
  2. See the error above

Expected behavior
This should work without error. git on the CLI works fine without error

Screenshots
Screenshot 2024-04-15 at 11 38 03 AM

Context (please complete the following information):

  • M2 MacOS 14.4.1
  • GitUI Version gitui nightly 2024-04-14
  • Rust version: cargo 1.77.1 (e52e36006 2024-03-26)

Additional context
Add any other context about the problem here.
@seanaye seanaye added the bug Something isn't working label Apr 15, 2024
@extrawurst
Copy link
Owner

Yeah right now we do not support calling a custom ssh program as you have configured

@extrawurst extrawurst changed the title Cant use commit signing [ssh signing] support custom signing program Apr 15, 2024
@extrawurst extrawurst added enhancement New feature or request and removed bug Something isn't working labels Apr 15, 2024
@seanaye
Copy link
Author

seanaye commented Apr 17, 2024

I am working on a PR to support this.

@seanaye seanaye linked a pull request Apr 19, 2024 that will close this issue
Open
4 tasks
@b1nhack b1nhack mentioned this issue May 17, 2024
Closed
4 tasks
@chirpcel
Copy link

chirpcel commented Jan 3, 2025

I'll take a look as this as the opened pull request seems to be abandoned

@chirpcel chirpcel linked a pull request Jan 4, 2025 that will close this issue
Draft
4 tasks
@chirpcel
Copy link

chirpcel commented Jan 4, 2025

First prototype is ready (see #2464), looking into support for key literal in .gitconfig and writing tests. Then I'll mark it as ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@extrawurst @seanaye @chirpcel